From: Heiko Carstens <hca@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
gor@linux.ibm.com, agordeev@linux.ibm.com, svens@linux.ibm.com,
gerald.schaefer@linux.ibm.com, borntraeger@de.ibm.com
Subject: Re: [PATCH v3 2/2] s390/pgtable: add missing hardware bits for puds, pmds
Date: Mon, 29 Apr 2024 15:11:49 +0200 [thread overview]
Message-ID: <20240429131149.29046-M-hca@linux.ibm.com> (raw)
In-Reply-To: <20240426120447.34318-3-imbrenda@linux.ibm.com>
On Fri, Apr 26, 2024 at 02:04:47PM +0200, Claudio Imbrenda wrote:
> Add the table type and ACCF validity bits to _SEGMENT_ENTRY_BITS and
> _SEGMENT_ENTRY_HARDWARE_BITS{,_LARGE}.
>
> For completeness, introduce _REGION3_ENTRY_HARDWARE_BITS_LARGE and
> _REGION3_ENTRY_HARDWARE_BITS, containing the hardware bits used for
> large puds and normal puds.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> arch/s390/include/asm/pgtable.h | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
...
> +#define _REGION3_ENTRY_HARDWARE_BITS_LARGE 0xffffffff8001073cUL
> +#define _REGION3_ENTRY_HARDWARE_BITS 0xfffffffffffff6ffUL
...
> +#define _SEGMENT_ENTRY_BITS 0xfffffffffffffe3fUL
> +#define _SEGMENT_ENTRY_HARDWARE_BITS 0xfffffffffffffe3cUL
> +#define _SEGMENT_ENTRY_HARDWARE_BITS_LARGE 0xfffffffffff1073cUL
Please resend and make sure the order (BITS, BITS_LARGE, ...) is the
same; then Alexander can pick this up.
For the definitions:
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2024-04-29 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 12:04 [PATCH v3 0/2] s390/pgtable: misc small improvements Claudio Imbrenda
2024-04-26 12:04 ` [PATCH v3 1/2] s390/pgtable: switch read and write softbits for puds Claudio Imbrenda
2024-04-26 12:04 ` [PATCH v3 2/2] s390/pgtable: add missing hardware bits for puds, pmds Claudio Imbrenda
2024-04-29 13:11 ` Heiko Carstens [this message]
2024-04-29 14:03 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429131149.29046-M-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox