From: Heiko Carstens <hca@linux.ibm.com>
To: linux-s390@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
lkft-triage@lists.linaro.org,
Linux Regressions <regressions@lists.linux.dev>,
imx@lists.linux.dev, Abel Vesa <abelvesa@kernel.org>,
Abel Vesa <abel.vesa@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Arnd Bergmann <arnd@arndb.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
Anders Roxell <anders.roxell@linaro.org>,
peng.fan@nxp.com
Subject: [PATCH] clk: imx: imx8mp: Add missing CONFIG_PM ifdefs
Date: Tue, 30 Apr 2024 16:16:09 +0200 [thread overview]
Message-ID: <20240430141609.2244416-1-hca@linux.ibm.com> (raw)
In-Reply-To: <CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com>
Add missing CONFIG_PM ifdefs to fix this allmodconfig compile error:
drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error:
'clk_imx8mp_audiomix_runtime_suspend' defined but not used
[-Werror=unused-function]
356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://lore.kernel.org/r/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com
Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for power saving")
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
drivers/clk/imx/clk-imx8mp-audiomix.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
index 574a032309c1..6549e55e94c9 100644
--- a/drivers/clk/imx/clk-imx8mp-audiomix.c
+++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
@@ -217,6 +217,8 @@ struct clk_imx8mp_audiomix_priv {
struct clk_hw_onecell_data clk_data;
};
+#ifdef CONFIG_PM
+
static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
{
struct clk_imx8mp_audiomix_priv *priv = dev_get_drvdata(dev);
@@ -232,6 +234,8 @@ static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
}
}
+#endif /* CONFIG_PM */
+
static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
{
struct clk_imx8mp_audiomix_priv *priv;
@@ -353,6 +357,8 @@ static int clk_imx8mp_audiomix_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_PM
+
static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
{
clk_imx8mp_audiomix_save_restore(dev, true);
@@ -367,6 +373,8 @@ static int clk_imx8mp_audiomix_runtime_resume(struct device *dev)
return 0;
}
+#endif /* CONFIG_PM */
+
static const struct dev_pm_ops clk_imx8mp_audiomix_pm_ops = {
SET_RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend,
clk_imx8mp_audiomix_runtime_resume, NULL)
--
2.40.1
next prev parent reply other threads:[~2024-04-30 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 20:43 s390: clk-imx8mp-audiomix.c:363:12: error: 'clk_imx8mp_audiomix_runtime_resume' defined but not used Naresh Kamboju
2024-04-30 14:16 ` Heiko Carstens [this message]
2024-04-30 14:30 ` [PATCH] clk: imx: imx8mp: Add missing CONFIG_PM ifdefs Arnd Bergmann
2024-04-30 14:40 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430141609.2244416-1-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=imx@lists.linux.dev \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mturquette@baylibre.com \
--cc=naresh.kamboju@linaro.org \
--cc=peng.fan@nxp.com \
--cc=regressions@lists.linux.dev \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox