Re: [RFC PATCH] net: Fix one page_pool page leak from skb_frag_unref

Jakub Kicinski
2024-04-26T23:09:01Z

On Thu, 25 Apr 2024 12:20:59 -0700 Mina Almasry wrote:
> - if (recycle && napi_pp_get_page(page))
> + if (napi_pp_get_page(page))

Pretty sure you can't do that. The "recycle" here is a concurrency
guarantee. A guarantee someone is holding a pp ref on that page,
a ref which will not go away while napi_pp_get_page() is executing.