From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9AB12DDBD; Wed, 1 May 2024 14:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714572773; cv=none; b=OsKviZjqeaMNZ746rxWLewVi2Bg2CnLLTcV3zrQkKSI2tuQfK6lc+NONrrCFWswM3FizDOpDnkXr/DqNxCplO6D0HzGlK+o0UndfZu+ec24UPIILStuafltnLC3IRbclwi/hztRhxWw024rGorzECPJpUUpsPqor045/OomUZBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714572773; c=relaxed/simple; bh=fgxzKQGhIkjktiZA/KPlfV5pis6w6LQ3+OD0G47qTM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tXXSAQJ9w3Kyx88+0Pr0sKcbOq5BLYmfkWPUVYy+eIT88+2t6NTbGWJdx9Gr68dsq2+cKWS3jx+AdttPQm4fjb85Ao3TxCwDezVQSWON2/4DOmV3V7XW1WTELn5GLzoDkyIqX+7NpgFenRa68zPlbNFpQIcCHoFeEIUufQXzK9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RKl9atsn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RKl9atsn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5A70C072AA; Wed, 1 May 2024 14:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714572772; bh=fgxzKQGhIkjktiZA/KPlfV5pis6w6LQ3+OD0G47qTM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RKl9atsnOsj/xFo+DR7RMrKYnOWbBnzRDKp6oK1U+t6NqGKRkLuug33aByA2jT4gR ovHyPx0RlPkGeR3/rDqKcUCWxldy0UcgxvizOpXphb3AY+YGKF1ztUjQa7/RRlKqXV iX/gvR2yPIlNov6CiBEa1ILMo1E8Np6KCJ3pdYRw= Date: Wed, 1 May 2024 16:12:48 +0200 From: Greg KH To: Shahar Avidar Cc: hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com, dan.carpenter@linaro.org, krzysztof.kozlowski@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: pi433: Use class_create instead of class_register. Message-ID: <2024050109-reward-vision-58e9@gregkh> References: <20240501055820.603272-1-ikobh7@gmail.com> <20240501055820.603272-2-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240501055820.603272-2-ikobh7@gmail.com> On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote: > Make use of a higher level API. What does this mean? > Reduce global memory allocation from struct class to pointer size. No, you increased memory allocation here, why do you think you reduced it? Also, this looks like a revert of commit f267da65bb6b ("staging: pi433: make pi433_class constant"), accepted a few months ago, why not just call it out as an explicit revert if that's what you want to do? class_create is going away "soon", why add this back when people are working so hard to remove its usage? What tutorial did you read that made you want to make this change? thanks, greg k-h