Re: [PATCH 19/39] sched_ext: Print sched_ext info when dumping stack

Peter Zijlstra
2024-06-24T12:46:39Z

On Wed, May 01, 2024 at 05:09:54AM -1000, Tejun Heo wrote:

> +static long jiffies_delta_msecs(unsigned long at, unsigned long now)
> +{
> + if (time_after(at, now))
> + return jiffies_to_msecs(at - now);
> + else
> + return -(long)jiffies_to_msecs(now - at);
> +}

You have this weird superfluous else:

if ()
return foo;
else
return bar;

pattern in multiple patches, please change that to:

if ()
return foo;
return bar;

Throughout the series.

Also, if we consider 2s complement, does the above actually make sense?