Re: [PATCH 19/39] sched_ext: Print sched_ext info when dumping stack

Tejun Heo
2024-06-24T18:34:40Z

Hello, Peter.

On Mon, Jun 24, 2024 at 02:46:18PM +0200, Peter Zijlstra wrote:
> On Wed, May 01, 2024 at 05:09:54AM -1000, Tejun Heo wrote:
>
> > +static long jiffies_delta_msecs(unsigned long at, unsigned long now)
> > +{
> > + if (time_after(at, now))
> > + return jiffies_to_msecs(at - now);
> > + else
> > + return -(long)jiffies_to_msecs(now - at);
> > +}
>
> You have this weird superfluous else:
>
> if ()
> return foo;
> else
> return bar;
>
> pattern in multiple patches, please change that to:
>
> if ()
> return foo;
> return bar;
>
> Throughout the series.

It's just my personal preference. When the if and else blocks are relatively
short and completely symmetric like the above case, using exlicit if/else
structure looks more immediately intuitive to me. If it isn't too bothersome
to everybody, I'd like to keep it that way.

> Also, if we consider 2s complement, does the above actually make sense?

Maybe we can update jiffifes_to_msecs() to be 2s complement transparent but
probably not a good idea given how many are calling it.

Thanks.

--
tejun