From: Levi Yun <ppbuk5246@gmail.com>
To: anna-maria@linutronix.de, frederic@kernel.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Levi Yun <ppbuk5246@gmail.com>
Subject: [PATCH] time/timgr: Fix wrong reference when level 0 group allocation failed
Date: Wed, 1 May 2024 20:51:16 +0100 [thread overview]
Message-ID: <20240501195116.62669-1-ppbuk5246@gmail.com> (raw)
When tmigr_setup_groups() failed level 0 group allocation,
next do while loop refers wrong local stack array location.
Changing group init do while loop with while loop to fix this problem.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
kernel/time/timer_migration.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
index ccba875d2234..84413114db5c 100644
--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -1596,7 +1596,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
} while (i < tmigr_hierarchy_levels);
- do {
+ while (i > 0) {
group = stack[--i];
if (err < 0) {
@@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
tmigr_connect_child_parent(child, group);
}
}
- } while (i > 0);
+ }
kfree(stack);
--
2.41.0
next reply other threads:[~2024-05-01 19:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 19:51 Levi Yun [this message]
2024-05-04 4:47 ` [PATCH] time/timgr: Fix wrong reference when level 0 group allocation failed Yun Levi
2024-05-04 10:09 ` Markus Elfring
2024-05-05 8:57 ` [PATCH RESEND] " Levi Yun
2024-05-05 10:23 ` Markus Elfring
2024-05-05 10:55 ` Yun Levi
2024-05-05 10:54 ` [PATCH v2] " Levi Yun
2024-05-05 17:07 ` [v2] " Markus Elfring
2024-05-06 4:10 ` [PATCH v3] " Levi Yun
2024-05-06 10:10 ` Frederic Weisbecker
2024-05-08 6:16 ` Anna-Maria Behnsen
2024-05-08 6:38 ` [v3] " Markus Elfring
2024-05-08 9:45 ` [tip: timers/urgent] timers/migration: Prevent out of bounds access on failure tip-bot2 for Levi Yun
2024-05-08 9:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501195116.62669-1-ppbuk5246@gmail.com \
--to=ppbuk5246@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox