From: Conor Dooley <conor@kernel.org>
To: Yunhui Cui <cuiyunhui@bytedance.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, bhelgaas@google.com,
james.morse@arm.com, jhugo@codeaurora.org, jeremy.linton@arm.com,
john.garry@huawei.com, Jonathan.Cameron@huawei.com,
pierre.gondois@arm.com, sudeep.holla@arm.com,
tiantao6@huawei.com
Subject: Re: [PATCH v4 1/3] riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init()
Date: Thu, 2 May 2024 17:28:18 +0100 [thread overview]
Message-ID: <20240502-secrecy-unleveled-e173419c54ec@spud> (raw)
In-Reply-To: <20240418034330.84721-1-cuiyunhui@bytedance.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Thu, Apr 18, 2024 at 11:43:28AM +0800, Yunhui Cui wrote:
> ci_leaf_init() is a declared static function. The implementation of the
> function body and the caller do not use the parameter (struct device_node
> *node) input parameter, so remove it.
>
> Fixes: 6a24915145c9 ("Revert "riscv: Set more data to cacheinfo"")
> Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
By the way, please use cover letters for multi patch patchsets. I don't
enjoy marking previous versions "superceded" by hand in patchwork.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-05-02 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 3:43 [PATCH v4 1/3] riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init() Yunhui Cui
2024-04-18 3:43 ` [PATCH v4 2/3] riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT Yunhui Cui
2024-04-18 8:41 ` Sudeep Holla
2024-04-19 6:27 ` [External] " yunhui cui
2024-04-19 15:28 ` Jeremy Linton
2024-04-23 11:03 ` [External] " yunhui cui
2024-04-30 3:16 ` yunhui cui
2024-05-02 16:37 ` Conor Dooley
2024-05-08 11:19 ` [External] " yunhui cui
2024-05-08 14:53 ` Palmer Dabbelt
2024-05-09 4:09 ` Sunil V L
2024-05-09 6:33 ` [External] " yunhui cui
2024-04-18 3:43 ` [PATCH v4 3/3] RISC-V: Select ACPI PPTT drivers Yunhui Cui
2024-05-02 16:28 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502-secrecy-unleveled-e173419c54ec@spud \
--to=conor@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=cuiyunhui@bytedance.com \
--cc=james.morse@arm.com \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox