From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
Luca Abeni <luca.abeni@santannapisa.it>,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
Thomas Gleixner <tglx@linutronix.de>,
Joel Fernandes <joel@joelfernandes.org>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Phil Auld <pauld@redhat.com>,
Suleiman Souhlal <suleiman@google.com>,
Youssef Esmat <youssefesmat@google.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>
Subject: Re: [PATCH V6 2/6] sched/deadline: Deferrable dl server
Date: Thu, 2 May 2024 10:45:04 +0200 [thread overview]
Message-ID: <20240502084504.GX30852@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <c4c6575d-5ea0-44ba-bbdc-eadad77dea81@redhat.com>
On Thu, May 02, 2024 at 10:35:02AM +0200, Daniel Bristot de Oliveira wrote:
> On 4/10/24 19:47, Peter Zijlstra wrote:
> >> +static enum hrtimer_restart dl_server_timer(struct hrtimer *timer, struct sched_dl_entity *dl_se)
> >> +{
> >> + struct rq *rq = rq_of_dl_se(dl_se);
> >> + enum hrtimer_restart restart = 0;
> >> + struct rq_flags rf;
> >> + u64 fw;
> >> +
> >> + rq_lock(rq, &rf);
> > guard(rq_lock)(rq, &rf);
>
> this is the way I found to get the &rf... inspired on sched_rr_get_interval():
>
> scoped_guard (rq_lock, rq) {
> struct rq_flags *rf = &scope.rf;
>
> is that right?
>
Yeah, it's a bit ugly, but yes.
next prev parent reply other threads:[~2024-05-02 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 17:27 [PATCH V6 0/6] SCHED_DEADLINE server infrastructure Daniel Bristot de Oliveira
2024-04-05 17:28 ` [PATCH V6 1/6] sched/fair: Add trivial fair server Daniel Bristot de Oliveira
2024-04-10 17:24 ` Peter Zijlstra
2024-04-11 7:28 ` Daniel Bristot de Oliveira
2024-04-05 17:28 ` [PATCH V6 2/6] sched/deadline: Deferrable dl server Daniel Bristot de Oliveira
2024-04-10 17:47 ` Peter Zijlstra
2024-04-11 7:57 ` Daniel Bristot de Oliveira
2024-05-02 8:35 ` Daniel Bristot de Oliveira
2024-05-02 8:45 ` Peter Zijlstra [this message]
2024-04-05 17:28 ` [PATCH V6 3/6] sched/fair: Fair server interface Daniel Bristot de Oliveira
2024-04-11 14:43 ` Peter Zijlstra
2024-04-11 15:02 ` Daniel Bristot de Oliveira
2024-04-12 7:43 ` Peter Zijlstra
2024-04-12 8:27 ` Daniel Bristot de Oliveira
2024-04-05 17:32 ` [PATCH V6 4/6] sched/core: Fix priority checking for DL server picks Daniel Bristot de Oliveira
2024-04-05 17:33 ` [PATCH V6 5/6] sched/core: Fix picking of tasks for core scheduling with DL server Daniel Bristot de Oliveira
2024-04-05 17:33 ` [PATCH V6 6/6] sched/rt: Remove default bandwidth control Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502084504.GX30852@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=vschneid@redhat.com \
--cc=youssefesmat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox