public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: linux@treblig.org
To: sudipm.mukherjee@gmail.com
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-parport@lists.infradead.org,
	"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 2/3] parport: Remove attach function pointer
Date: Thu,  2 May 2024 16:48:22 +0100	[thread overview]
Message-ID: <20240502154823.67235-3-linux@treblig.org> (raw)
In-Reply-To: <20240502154823.67235-1-linux@treblig.org>

From: "Dr. David Alan Gilbert" <linux@treblig.org>

The attach function pointers haven't actually been called since:
  'commit 3275158fa52a ("parport: remove use of devmodel")'
topped adding entries to the drivers list.

If you're converting a driver, look at the 'match_port' function
pointer instead.

(There are lots of comment references to 'attach' all over, but they
probably need some deeper understanding to check the semantics
to see if they can be replaced by match_port).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/parport.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/parport.h b/include/linux/parport.h
index 2a4424b601565..190de3569e25c 100644
--- a/include/linux/parport.h
+++ b/include/linux/parport.h
@@ -252,7 +252,6 @@ struct parport {
 
 struct parport_driver {
 	const char *name;
-	void (*attach) (struct parport *);
 	void (*detach) (struct parport *);
 	void (*match_port)(struct parport *);
 	int (*probe)(struct pardevice *);
-- 
2.44.0


  parent reply	other threads:[~2024-05-02 16:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 15:48 [PATCH 0/3] parport: Cleanup some pre-devmodel code linux
2024-05-02 15:48 ` [PATCH 1/3] parport: Remove 'drivers' list linux
2024-06-30 21:00   ` Sudip Mukherjee (Codethink)
2024-06-30 22:46     ` Dr. David Alan Gilbert
2024-05-02 15:48 ` linux [this message]
2024-06-30 21:01   ` [PATCH 2/3] parport: Remove attach function pointer Sudip Mukherjee
2024-05-02 15:48 ` [PATCH 3/3] parport: Remove parport_driver.devmodel linux
2024-06-30 21:03   ` Sudip Mukherjee
2024-05-16 10:46 ` [PATCH 0/3] parport: Cleanup some pre-devmodel code Dr. David Alan Gilbert
2024-06-03 17:39   ` Dr. David Alan Gilbert
2024-06-26 15:41     ` Dr. David Alan Gilbert
2024-06-27  8:51       ` Sudip Mukherjee
2024-06-27 11:34         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240502154823.67235-3-linux@treblig.org \
    --to=linux@treblig.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox