* [PATCH] s390: Remove comment about TIF_FPU
@ 2024-05-02 17:25 Thomas Huth
2024-05-03 7:50 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2024-05-02 17:25 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Vasily Gorbik, Alexander Gordeev
Cc: linux-kernel, Christian Borntraeger, Sven Schnelle
It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
so we should not mention TIF_FPU in the comment here anymore.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
arch/s390/kernel/process.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
index dd456b475861..3e7df2e579f1 100644
--- a/arch/s390/kernel/process.c
+++ b/arch/s390/kernel/process.c
@@ -88,8 +88,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
{
/*
* Save the floating-point or vector register state of the current
- * task and set the TIF_FPU flag to lazy restore the FPU register
- * state when returning to user space.
+ * task.
*/
save_user_fpu_regs();
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] s390: Remove comment about TIF_FPU
2024-05-02 17:25 [PATCH] s390: Remove comment about TIF_FPU Thomas Huth
@ 2024-05-03 7:50 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2024-05-03 7:50 UTC (permalink / raw)
To: Thomas Huth
Cc: linux-s390, Vasily Gorbik, Alexander Gordeev, linux-kernel,
Christian Borntraeger, Sven Schnelle
On Thu, May 02, 2024 at 07:25:27PM +0200, Thomas Huth wrote:
> It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
> so we should not mention TIF_FPU in the comment here anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> arch/s390/kernel/process.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
> index dd456b475861..3e7df2e579f1 100644
> --- a/arch/s390/kernel/process.c
> +++ b/arch/s390/kernel/process.c
> @@ -88,8 +88,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
> {
> /*
> * Save the floating-point or vector register state of the current
> - * task and set the TIF_FPU flag to lazy restore the FPU register
> - * state when returning to user space.
> + * task.
> */
> save_user_fpu_regs();
Could you change your patch to remove the whole comment instead, please?
Without the TIF_FPU part the comment becomes quite pointless, since it
only documents the obvious.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-03 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 17:25 [PATCH] s390: Remove comment about TIF_FPU Thomas Huth
2024-05-03 7:50 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox