From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB1E1CA92; Sat, 4 May 2024 12:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714824529; cv=none; b=JeX4f8P/k44Yqtby/U4ueZ9bWiex6DLPOqA/mk/PfDMwf7Mmk3eaUVa6/0zRo82J6YzGQiEKlgcqJgSk9bKU7yYINNNxD16+Tydd+SoRfqvdOjyD6Z6IRUmmWEl9WLE6wOgAZSUPGN7irErr9996Z1WWxQahJd8pyJqB7Sk7Shs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714824529; c=relaxed/simple; bh=0fbCjFhfYivYU11Wu3h38hXHo8+BtXT5qZrpETfvx4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xp4+LZqk8aUpHlhO7ksUpvIXmsmBcy7QyN1BS7Ni1WTvHnELoyNP2VaFaNH9OOeFZ62Jsn1tN4lsM4sdM0hGFiIAFCfzo+qbW97xMD1BmJzAyDnQt3bueoOrPYJAEwnaXu/SYRm070vBgbazlrc3Hph0VXA88De+RAT9uSTQtUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=0+jhOA9f; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="0+jhOA9f" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 358DF1FC05; Sat, 4 May 2024 13:58:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1714823914; bh=Cxi2xIblwS9mptHHfMVehasWNU2Xj3zceCDJW5esh28=; h=From:To:Subject; b=0+jhOA9f8ALr+I2+CVVeXivn1jsPLgkjgQzNMkSP67tVBmbNWhaEDK7XMui370Tav QJH/Gbab/x1vGoOa6aULtSDxQbjUoeGtjaqbmdm+r4lg4/V/83uMNNWwLQOPN97Kuo FhxeB9Jg7DOA9q14ZAT9tt357TJKap9imbN/ctgawj91nGOOz3YOZXC9Ldwe54elGO YZ/hkc814KoX8VFz/XcOe8a34vlfzgkXcEZ3VMuq+0Qdlmy9zhxU3bD9Lb16jq2j3m 7rabgG7d42kr0USzKSaw7Mg1yUe6aVLpZVACwe13D9KDW/cJR6d1W7jk5Zjze9N/1C ZbVpGVPTNkkyQ== Date: Sat, 4 May 2024 13:58:28 +0200 From: Francesco Dolcini To: "Peng Fan (OSS)" Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Bai , Ye Li , Dong Aisheng , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abel Vesa , Peng Fan , Florin Pavelescu , Viorel Suman Subject: Re: [PATCH 07/18] clk: imx: pll14xx: potential integer overflow eliminated by casting to u64 Message-ID: <20240504115828.GA3666@francesco-nb> References: <20240504-imx-clk-v1-0-f7915489d58d@nxp.com> <20240504-imx-clk-v1-7-f7915489d58d@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240504-imx-clk-v1-7-f7915489d58d@nxp.com> Hello Peng, On Sat, May 04, 2024 at 08:49:00AM +0800, Peng Fan (OSS) wrote: > From: Florin Pavelescu > > Cast to u64, so that multiplications and additions will be done > in 64-bit arithmetic (and the results will also be 64-bit) > and the possibility of integer overflow is eliminated. > > Fix Unintentional integer overflow reported by Coverity Fixes tag if this is a fix? It would be interesting in general if this can be trigger in real life and with which side effects or if we are just silencing the tool