public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: [PATCH 04/10] kconfig: used linked list in sym_set_changed()
Date: Sun,  5 May 2024 03:33:27 +0900	[thread overview]
Message-ID: <20240504183333.2031860-4-masahiroy@kernel.org> (raw)
In-Reply-To: <20240504183333.2031860-1-masahiroy@kernel.org>

Following the approach employed in commit bedf92362317 ("kconfig: use
linked list in get_symbol_str() to iterate over menus"), simplify the
iteration on the menus of the specified symbol.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/symbol.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index b909c64f3bac..8512c29c84bb 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -152,13 +152,11 @@ static void sym_validate_range(struct symbol *sym)
 
 static void sym_set_changed(struct symbol *sym)
 {
-	struct property *prop;
+	struct menu *menu;
 
 	sym->flags |= SYMBOL_CHANGED;
-	for (prop = sym->prop; prop; prop = prop->next) {
-		if (prop->menu)
-			prop->menu->flags |= MENU_CHANGED;
-	}
+	list_for_each_entry(menu, &sym->menus, link)
+		menu->flags |= MENU_CHANGED;
 }
 
 static void sym_set_all_changed(void)
-- 
2.40.1


  parent reply	other threads:[~2024-05-04 18:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-04 18:33 [PATCH 01/10] kconfig: gconf: redraw pane correctly after loading a config file Masahiro Yamada
2024-05-04 18:33 ` [PATCH 02/10] kconfig: gconf: remove debug code Masahiro Yamada
2024-05-04 18:33 ` [PATCH 03/10] kconfig: gconf: use MENU_CHANGED instead of SYMBOL_CHANGED Masahiro Yamada
2024-05-04 18:33 ` Masahiro Yamada [this message]
2024-05-04 18:33 ` [PATCH 05/10] kconfig: add sym_get_choice_menu() helper Masahiro Yamada
2024-05-04 18:33 ` [PATCH 06/10] kconfig: use sym_get_choice_menu() in conf_write_defconfig() Masahiro Yamada
2024-05-04 18:33 ` [PATCH 07/10] kconfig: use menu_list_for_each_sym() in sym_check_choice_deps() Masahiro Yamada
2024-05-04 18:33 ` [PATCH 08/10] kconfig: turn conf_choice() into void function Masahiro Yamada
2024-05-04 18:33 ` [PATCH 09/10] kconfig: turn missing prompt for choice members into error Masahiro Yamada
2024-05-04 18:33 ` [PATCH 10/10] kconfig: turn defaults and additional " Masahiro Yamada
2024-05-05 15:01   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240504183333.2031860-4-masahiroy@kernel.org \
    --to=masahiroy@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox