Re: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs driver

Mark Brown
2024-05-09T04:50:52Z

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

On Tue, May 07, 2024 at 12:13:43PM +0800, Chen-Yu Tsai wrote:
> From: Samuel Holland <samuel@sholland.org>
>
> D1 contains two pairs of LDOs, "analog" LDOs and "system" LDOs. They are
> similar and can share a driver, but only the system LDOs have a DT
> binding defined so far.

This doesn't build on at least multi_v5_defconfig, multi_v7_defconfig
and arm64 defconfig:

/build/stage/linux/drivers/regulator/sun20i-regulator.c: In function ‘sun20i_reg
ulator_probe’:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:16: error: implicit
declaration of function ‘of_device_get_match_data’ [-Werror=implicit-function-de
claration]
111 | data = of_device_get_match_data(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:14: warning: assignm
ent to ‘const struct sun20i_regulator_data *’ from ‘int’ makes pointer from inte
ger without a cast [-Wint-conversion]
111 | data = of_device_get_match_data(dev);
| ^
/build/stage/linux/drivers/regulator/sun20i-regulator.c: At top level:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: error: array typ
e has incomplete element type ‘struct of_device_id’
136 | static const struct of_device_id sun20i_regulator_of_match[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: warning: ‘sun20i
_regulator_of_match’ defined but not used [-Wunused-variable]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]