Aw: Re: [RFC v1 1/5] dt-bindings: leds: add led trigger netdev

Frank Wunderlich
2024-05-06T17:10:29Z

Hi

> Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>, "Michael Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@kernel.org>, "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Eric Woudstra" <ericwouds@gmail.com>, "Tianling Shen" <cnsztl@immortalwrt.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
> Betreff: Re: [RFC v1 1/5] dt-bindings: leds: add led trigger netdev
>
> On 05/05/2024 18:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add led trigger implemented with config-symbol LEDS_TRIGGER_NETDEV to
> > binding.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> > ---
> > Documentation/devicetree/bindings/leds/common.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index 8a3c2398b10c..bf9a101e4d42 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -113,6 +113,8 @@ properties:
> > # LED indicates NAND memory activity (deprecated),
> > # in new implementations use "mtd"
> > - nand-disk
> > + # LED indicates network activity
> > + - netdev
>
> "dev" is redundant (there is no flash-dev or usb-host-dev). Two network
> interfaces are already provided, so your commit msg must provide
> rationale why this is not enough and why this is useful/needed.

i only see 1 network binding...and this is labeled/described with wlan and phy

# LED is triggered by WLAN activity
- pattern: "^phy[0-9]+tx$"

which second do you mean?

btw. usb + disk has 3 trigger and "netdev" is already used in some dts, so i thought adding the binding is a good idea

arch/arm/boot/dts/rockchip/rk3128-xpi-3128.dts:107: * linux,default-trigger = "netdev";
arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts:52: linux,default-trigger = "netdev";
arch/arm/boot/dts/intel/ixp/intel-ixp42x-dlink-dsm-g600.dts:51: linux,default-trigger = "netdev";
arch/arm/boot/dts/intel/ixp/intel-ixp42x-iomega-nas100d.dts:39: linux,default-trigger = "netdev";
arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts:138: linux,default-trigger = "netdev";
arch/arm/boot/dts/ti/omap/am335x-netcan-plus-1xx.dts:27: linux,default-trigger = "netdev";
arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:107: linux,default-trigger = "netdev";
arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:113: linux,default-trigger = "netdev";

first one has it as comment that not yet in binding and with not that it needs to be set in userspace
like Daniel stated in the dts patch (does not work for phys)...so i drop this patch and the property
in the dts.

> Best regards,
> Krzysztof

regards Frank