From: kernel test robot <lkp@intel.com>
To: Perry Yuan <perry.yuan@amd.com>,
rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
viresh.kumar@linaro.org, Ray.Huang@amd.com,
gautham.shenoy@amd.com, Borislav.Petkov@amd.com
Cc: oe-kbuild-all@lists.linux.dev, Alexander.Deucher@amd.com,
Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] cpufreq: amd-pstate: optimiza the initial frequency values verification
Date: Wed, 8 May 2024 05:02:50 +0800 [thread overview]
Message-ID: <202405080431.BPU6Yg9s-lkp@intel.com> (raw)
In-Reply-To: <0049ad44052b051cf57d1059bf71b7ce227a5f21.1715065568.git.perry.yuan@amd.com>
Hi Perry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge next-20240507]
[cannot apply to tip/x86/core linus/master v6.9-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Perry-Yuan/cpufreq-amd-pstate-optimiza-the-initial-frequency-values-verification/20240507-151930
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/0049ad44052b051cf57d1059bf71b7ce227a5f21.1715065568.git.perry.yuan%40amd.com
patch subject: [PATCH 01/11] cpufreq: amd-pstate: optimiza the initial frequency values verification
config: x86_64-randconfig-102-20240507 (https://download.01.org/0day-ci/archive/20240508/202405080431.BPU6Yg9s-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240508/202405080431.BPU6Yg9s-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405080431.BPU6Yg9s-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/cpufreq/amd-pstate.c: In function 'amd_pstate_cpu_init':
>> drivers/cpufreq/amd-pstate.c:899:33: warning: variable 'nominal_freq' set but not used [-Wunused-but-set-variable]
899 | int min_freq, max_freq, nominal_freq, ret;
| ^~~~~~~~~~~~
drivers/cpufreq/amd-pstate.c: In function 'amd_pstate_epp_cpu_init':
drivers/cpufreq/amd-pstate.c:1350:33: warning: variable 'nominal_freq' set but not used [-Wunused-but-set-variable]
1350 | int min_freq, max_freq, nominal_freq, ret;
| ^~~~~~~~~~~~
vim +/nominal_freq +899 drivers/cpufreq/amd-pstate.c
5547c0ebfc2efd Perry Yuan 2024-04-25 896
ec437d71db77a1 Huang Rui 2021-12-24 897 static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
ec437d71db77a1 Huang Rui 2021-12-24 898 {
5c3fd1edaa8b4c Perry Yuan 2024-04-30 @899 int min_freq, max_freq, nominal_freq, ret;
ec437d71db77a1 Huang Rui 2021-12-24 900 struct device *dev;
ec437d71db77a1 Huang Rui 2021-12-24 901 struct amd_cpudata *cpudata;
ec437d71db77a1 Huang Rui 2021-12-24 902
919f4557696939 Wyes Karny 2022-11-17 903 /*
919f4557696939 Wyes Karny 2022-11-17 904 * Resetting PERF_CTL_MSR will put the CPU in P0 frequency,
919f4557696939 Wyes Karny 2022-11-17 905 * which is ideal for initialization process.
919f4557696939 Wyes Karny 2022-11-17 906 */
919f4557696939 Wyes Karny 2022-11-17 907 amd_perf_ctl_reset(policy->cpu);
ec437d71db77a1 Huang Rui 2021-12-24 908 dev = get_cpu_device(policy->cpu);
ec437d71db77a1 Huang Rui 2021-12-24 909 if (!dev)
ec437d71db77a1 Huang Rui 2021-12-24 910 return -ENODEV;
ec437d71db77a1 Huang Rui 2021-12-24 911
ec437d71db77a1 Huang Rui 2021-12-24 912 cpudata = kzalloc(sizeof(*cpudata), GFP_KERNEL);
ec437d71db77a1 Huang Rui 2021-12-24 913 if (!cpudata)
ec437d71db77a1 Huang Rui 2021-12-24 914 return -ENOMEM;
ec437d71db77a1 Huang Rui 2021-12-24 915
ec437d71db77a1 Huang Rui 2021-12-24 916 cpudata->cpu = policy->cpu;
ec437d71db77a1 Huang Rui 2021-12-24 917
f3a052391822b7 Meng Li 2024-01-19 918 amd_pstate_init_prefcore(cpudata);
f3a052391822b7 Meng Li 2024-01-19 919
ec437d71db77a1 Huang Rui 2021-12-24 920 ret = amd_pstate_init_perf(cpudata);
ec437d71db77a1 Huang Rui 2021-12-24 921 if (ret)
41271016dfa4a0 Huang Rui 2021-12-24 922 goto free_cpudata1;
ec437d71db77a1 Huang Rui 2021-12-24 923
5547c0ebfc2efd Perry Yuan 2024-04-25 924 ret = amd_pstate_init_freq(cpudata);
5547c0ebfc2efd Perry Yuan 2024-04-25 925 if (ret)
5547c0ebfc2efd Perry Yuan 2024-04-25 926 goto free_cpudata1;
5547c0ebfc2efd Perry Yuan 2024-04-25 927
3cbbe8871a2fb8 Gautham R. Shenoy 2024-04-25 928 min_freq = READ_ONCE(cpudata->min_freq);
3cbbe8871a2fb8 Gautham R. Shenoy 2024-04-25 929 max_freq = READ_ONCE(cpudata->max_freq);
3cbbe8871a2fb8 Gautham R. Shenoy 2024-04-25 930 nominal_freq = READ_ONCE(cpudata->nominal_freq);
ec437d71db77a1 Huang Rui 2021-12-24 931
069a2bb8c48c43 Perry Yuan 2024-04-25 932 policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu);
069a2bb8c48c43 Perry Yuan 2024-04-25 933 policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu);
ec437d71db77a1 Huang Rui 2021-12-24 934
ec437d71db77a1 Huang Rui 2021-12-24 935 policy->min = min_freq;
ec437d71db77a1 Huang Rui 2021-12-24 936 policy->max = max_freq;
ec437d71db77a1 Huang Rui 2021-12-24 937
ec437d71db77a1 Huang Rui 2021-12-24 938 policy->cpuinfo.min_freq = min_freq;
ec437d71db77a1 Huang Rui 2021-12-24 939 policy->cpuinfo.max_freq = max_freq;
ec437d71db77a1 Huang Rui 2021-12-24 940
ec437d71db77a1 Huang Rui 2021-12-24 941 /* It will be updated by governor */
ec437d71db77a1 Huang Rui 2021-12-24 942 policy->cur = policy->cpuinfo.min_freq;
ec437d71db77a1 Huang Rui 2021-12-24 943
e059c184da47e9 Huang Rui 2021-12-24 944 if (boot_cpu_has(X86_FEATURE_CPPC))
1d215f0319c206 Huang Rui 2021-12-24 945 policy->fast_switch_possible = true;
1d215f0319c206 Huang Rui 2021-12-24 946
41271016dfa4a0 Huang Rui 2021-12-24 947 ret = freq_qos_add_request(&policy->constraints, &cpudata->req[0],
41271016dfa4a0 Huang Rui 2021-12-24 948 FREQ_QOS_MIN, policy->cpuinfo.min_freq);
41271016dfa4a0 Huang Rui 2021-12-24 949 if (ret < 0) {
41271016dfa4a0 Huang Rui 2021-12-24 950 dev_err(dev, "Failed to add min-freq constraint (%d)\n", ret);
41271016dfa4a0 Huang Rui 2021-12-24 951 goto free_cpudata1;
41271016dfa4a0 Huang Rui 2021-12-24 952 }
41271016dfa4a0 Huang Rui 2021-12-24 953
41271016dfa4a0 Huang Rui 2021-12-24 954 ret = freq_qos_add_request(&policy->constraints, &cpudata->req[1],
41271016dfa4a0 Huang Rui 2021-12-24 955 FREQ_QOS_MAX, policy->cpuinfo.max_freq);
41271016dfa4a0 Huang Rui 2021-12-24 956 if (ret < 0) {
41271016dfa4a0 Huang Rui 2021-12-24 957 dev_err(dev, "Failed to add max-freq constraint (%d)\n", ret);
41271016dfa4a0 Huang Rui 2021-12-24 958 goto free_cpudata2;
41271016dfa4a0 Huang Rui 2021-12-24 959 }
41271016dfa4a0 Huang Rui 2021-12-24 960
febab20caebac9 Wyes Karny 2023-11-17 961 cpudata->max_limit_freq = max_freq;
febab20caebac9 Wyes Karny 2023-11-17 962 cpudata->min_limit_freq = min_freq;
ec437d71db77a1 Huang Rui 2021-12-24 963
ec437d71db77a1 Huang Rui 2021-12-24 964 policy->driver_data = cpudata;
ec437d71db77a1 Huang Rui 2021-12-24 965
41271016dfa4a0 Huang Rui 2021-12-24 966 amd_pstate_boost_init(cpudata);
abd61c08ef349a Perry Yuan 2023-01-31 967 if (!current_pstate_driver->adjust_perf)
abd61c08ef349a Perry Yuan 2023-01-31 968 current_pstate_driver->adjust_perf = amd_pstate_adjust_perf;
41271016dfa4a0 Huang Rui 2021-12-24 969
ec437d71db77a1 Huang Rui 2021-12-24 970 return 0;
ec437d71db77a1 Huang Rui 2021-12-24 971
41271016dfa4a0 Huang Rui 2021-12-24 972 free_cpudata2:
41271016dfa4a0 Huang Rui 2021-12-24 973 freq_qos_remove_request(&cpudata->req[0]);
41271016dfa4a0 Huang Rui 2021-12-24 974 free_cpudata1:
ec437d71db77a1 Huang Rui 2021-12-24 975 kfree(cpudata);
ec437d71db77a1 Huang Rui 2021-12-24 976 return ret;
ec437d71db77a1 Huang Rui 2021-12-24 977 }
ec437d71db77a1 Huang Rui 2021-12-24 978
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-05-07 21:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 7:15 [PATCH 00/11] AMD Pstate Driver Fixes and Improvements Perry Yuan
2024-05-07 7:15 ` [PATCH 01/11] cpufreq: amd-pstate: optimiza the initial frequency values verification Perry Yuan
2024-05-07 14:44 ` Mario Limonciello
2024-05-07 21:02 ` kernel test robot [this message]
2024-05-07 7:15 ` [PATCH 02/11] cpufreq: amd-pstate: show CPPC debug message if CPPC is not supported Perry Yuan
2024-05-07 14:45 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 03/11] cpufreq: amd-pstate: add debug message while CPPC is supported and disabled by SBIOS Perry Yuan
2024-05-07 14:55 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 04/11] Documentation: PM: amd-pstate: introducing recommended reboot requirement during driver switch Perry Yuan
2024-05-07 7:15 ` [PATCH 05/11] Documentation: PM: amd-pstate: add debugging section for driver loading failure Perry Yuan
2024-05-07 15:01 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 06/11] Documentation: PM: amd-pstate: add guide mode to the Operation mode Perry Yuan
2024-05-07 15:02 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 07/11] cpufreq: amd-pstate: switch boot_cpu_has() to cpu_feature_enabled() Perry Yuan
2024-05-07 15:03 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 08/11] x86/cpufeatures: Add feature bits for AMD heterogeneous processor Perry Yuan
2024-05-07 7:15 ` [PATCH 09/11] cpufreq: amd-pstate: implement heterogeneous core topology for highest performance initialization Perry Yuan
2024-05-07 15:19 ` Mario Limonciello
2024-05-09 16:36 ` Yuan, Perry
2024-05-07 18:14 ` kernel test robot
2024-05-07 19:40 ` kernel test robot
2024-05-07 7:15 ` [PATCH 10/11] cpufreq: amd-pstate: fix the highest frequency issue which limit performance Perry Yuan
2024-05-07 15:23 ` Mario Limonciello
2024-05-07 7:15 ` [PATCH 11/11] cpufreq: amd-pstate: automatically load pstate driver by default Perry Yuan
2024-05-07 14:41 ` Mario Limonciello
2024-05-08 15:20 ` Oleksandr Natalenko
2024-05-08 15:24 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405080431.BPU6Yg9s-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=perry.yuan@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox