* [PATCH] firewire: core: fix type of timestamp for async_inbound_template tracepoints events
@ 2024-05-06 8:21 Takashi Sakamoto
2024-05-06 8:21 ` [PATCH] firewire: core: remove flag and width from u64 formats of " Takashi Sakamoto
2024-05-08 9:54 ` [PATCH] firewire: core: fix type of timestamp for async_inbound_template " Takashi Sakamoto
0 siblings, 2 replies; 4+ messages in thread
From: Takashi Sakamoto @ 2024-05-06 8:21 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
The type of time stamp should be u16, instead of u8.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
include/trace/events/firewire.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
index cd6931b134ee..d695a560673f 100644
--- a/include/trace/events/firewire.h
+++ b/include/trace/events/firewire.h
@@ -106,7 +106,7 @@ DECLARE_EVENT_CLASS(async_inbound_template,
__field(u8, generation)
__field(u8, scode)
__field(u8, status)
- __field(u8, timestamp)
+ __field(u16, timestamp)
__array(u32, header, ASYNC_HEADER_QUADLET_COUNT)
__dynamic_array(u32, data, data_count)
),
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] firewire: core: remove flag and width from u64 formats of tracepoints events
2024-05-06 8:21 [PATCH] firewire: core: fix type of timestamp for async_inbound_template tracepoints events Takashi Sakamoto
@ 2024-05-06 8:21 ` Takashi Sakamoto
2024-05-08 9:54 ` Takashi Sakamoto
2024-05-08 9:54 ` [PATCH] firewire: core: fix type of timestamp for async_inbound_template " Takashi Sakamoto
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Sakamoto @ 2024-05-06 8:21 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
The pointer to fw_packet structure is passed to ring buffer of tracepoints
framework as the value of u64 type. '0x%016llx' is used for the print
format of value, while the flag and width are useless in the case.
This commit removes them.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
include/trace/events/firewire.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
index 4163959be57a..cd6931b134ee 100644
--- a/include/trace/events/firewire.h
+++ b/include/trace/events/firewire.h
@@ -221,7 +221,7 @@ TRACE_EVENT(async_phy_outbound_initiate,
__entry->second_quadlet = second_quadlet
),
TP_printk(
- "packet=0x%016llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
+ "packet=0x%llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
__entry->packet,
__entry->generation,
__entry->first_quadlet,
@@ -245,7 +245,7 @@ TRACE_EVENT(async_phy_outbound_complete,
__entry->timestamp = timestamp;
),
TP_printk(
- "packet=0x%016llx generation=%u status=%u timestamp=0x%04x",
+ "packet=0x%llx generation=%u status=%u timestamp=0x%04x",
__entry->packet,
__entry->generation,
__entry->status,
@@ -273,7 +273,7 @@ TRACE_EVENT(async_phy_inbound,
__entry->second_quadlet = second_quadlet
),
TP_printk(
- "packet=0x%016llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
+ "packet=0x%llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
__entry->packet,
__entry->generation,
__entry->status,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] firewire: core: fix type of timestamp for async_inbound_template tracepoints events
2024-05-06 8:21 [PATCH] firewire: core: fix type of timestamp for async_inbound_template tracepoints events Takashi Sakamoto
2024-05-06 8:21 ` [PATCH] firewire: core: remove flag and width from u64 formats of " Takashi Sakamoto
@ 2024-05-08 9:54 ` Takashi Sakamoto
1 sibling, 0 replies; 4+ messages in thread
From: Takashi Sakamoto @ 2024-05-08 9:54 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
On Mon, May 06, 2024 at 05:21:53PM +0900, Takashi Sakamoto wrote:
> The type of time stamp should be u16, instead of u8.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> include/trace/events/firewire.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
> index cd6931b134ee..d695a560673f 100644
> --- a/include/trace/events/firewire.h
> +++ b/include/trace/events/firewire.h
> @@ -106,7 +106,7 @@ DECLARE_EVENT_CLASS(async_inbound_template,
> __field(u8, generation)
> __field(u8, scode)
> __field(u8, status)
> - __field(u8, timestamp)
> + __field(u16, timestamp)
> __array(u32, header, ASYNC_HEADER_QUADLET_COUNT)
> __dynamic_array(u32, data, data_count)
> ),
> --
> 2.43.0
Applied to for-next branch.
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firewire: core: remove flag and width from u64 formats of tracepoints events
2024-05-06 8:21 ` [PATCH] firewire: core: remove flag and width from u64 formats of " Takashi Sakamoto
@ 2024-05-08 9:54 ` Takashi Sakamoto
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Sakamoto @ 2024-05-08 9:54 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
On Mon, May 06, 2024 at 05:21:54PM +0900, Takashi Sakamoto wrote:
> The pointer to fw_packet structure is passed to ring buffer of tracepoints
> framework as the value of u64 type. '0x%016llx' is used for the print
> format of value, while the flag and width are useless in the case.
>
> This commit removes them.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> include/trace/events/firewire.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
> index 4163959be57a..cd6931b134ee 100644
> --- a/include/trace/events/firewire.h
> +++ b/include/trace/events/firewire.h
> @@ -221,7 +221,7 @@ TRACE_EVENT(async_phy_outbound_initiate,
> __entry->second_quadlet = second_quadlet
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
> + "packet=0x%llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
> __entry->packet,
> __entry->generation,
> __entry->first_quadlet,
> @@ -245,7 +245,7 @@ TRACE_EVENT(async_phy_outbound_complete,
> __entry->timestamp = timestamp;
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u status=%u timestamp=0x%04x",
> + "packet=0x%llx generation=%u status=%u timestamp=0x%04x",
> __entry->packet,
> __entry->generation,
> __entry->status,
> @@ -273,7 +273,7 @@ TRACE_EVENT(async_phy_inbound,
> __entry->second_quadlet = second_quadlet
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
> + "packet=0x%llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
> __entry->packet,
> __entry->generation,
> __entry->status,
> --
> 2.43.0
Applied to for-next branch.
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-08 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-06 8:21 [PATCH] firewire: core: fix type of timestamp for async_inbound_template tracepoints events Takashi Sakamoto
2024-05-06 8:21 ` [PATCH] firewire: core: remove flag and width from u64 formats of " Takashi Sakamoto
2024-05-08 9:54 ` Takashi Sakamoto
2024-05-08 9:54 ` [PATCH] firewire: core: fix type of timestamp for async_inbound_template " Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox