public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Manish Chopra" <manishc@marvell.com>,
	"Przemek Kitszel" <przemyslaw.kitszel@intel.com>
Subject: [PATCH net-next v2 00/14] net: qede: convert filter code to use extack
Date: Wed,  8 May 2024 14:33:48 +0000	[thread overview]
Message-ID: <20240508143404.95901-1-ast@fiberby.net> (raw)

This series converts the filter code in the qede driver
to use NL_SET_ERR_MSG_*(extack, ...) for error handling.

Patch 1-12 converts qede_parse_flow_attr() to use extack,
along with all it's static helper functions.

qede_parse_flow_attr() is used in two places:
- qede_add_tc_flower_fltr()
- qede_flow_spec_to_rule()

In the latter call site extack is faked in the same way as
is done in mlxsw (patch 12).

While the conversion is going on, some error messages are silenced
in between patch 1-12. If wanted could squash patch 1-12 in a v3, but
I felt that it would be easier to review as 12 more trivial patches.

Patch 13 and 14, finishes up by converting qede_parse_actions(),
and ensures that extack is propagated to it, in both call contexts.

---
Changelog:

v2:
- Reworked to always add extack as last argument. (Requested by Przemek)

v1: https://lore.kernel.org/netdev/20240507104421.1628139-1-ast@fiberby.net/

Asbjørn Sloth Tønnesen (14):
  net: qede: use extack in qede_flow_parse_ports()
  net: qede: use extack in qede_set_v6_tuple_to_profile()
  net: qede: use extack in qede_set_v4_tuple_to_profile()
  net: qede: use extack in qede_flow_parse_v6_common()
  net: qede: use extack in qede_flow_parse_v4_common()
  net: qede: use extack in qede_flow_parse_tcp_v6()
  net: qede: use extack in qede_flow_parse_tcp_v4()
  net: qede: use extack in qede_flow_parse_udp_v6()
  net: qede: use extack in qede_flow_parse_udp_v4()
  net: qede: add extack in qede_add_tc_flower_fltr()
  net: qede: use extack in qede_parse_flow_attr()
  net: qede: use faked extack in qede_flow_spec_to_rule()
  net: qede: propagate extack through qede_flow_spec_validate()
  net: qede: use extack in qede_parse_actions()

 .../net/ethernet/qlogic/qede/qede_filter.c    | 114 ++++++++++--------
 1 file changed, 63 insertions(+), 51 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-05-08 14:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 14:33 Asbjørn Sloth Tønnesen [this message]
2024-05-08 14:33 ` [PATCH net-next v2 01/14] net: qede: use extack in qede_flow_parse_ports() Asbjørn Sloth Tønnesen
2024-05-10 11:26   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 02/14] net: qede: use extack in qede_set_v6_tuple_to_profile() Asbjørn Sloth Tønnesen
2024-05-10 11:26   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 03/14] net: qede: use extack in qede_set_v4_tuple_to_profile() Asbjørn Sloth Tønnesen
2024-05-10 11:27   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 04/14] net: qede: use extack in qede_flow_parse_v6_common() Asbjørn Sloth Tønnesen
2024-05-10 11:27   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 05/14] net: qede: use extack in qede_flow_parse_v4_common() Asbjørn Sloth Tønnesen
2024-05-10 11:27   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 06/14] net: qede: use extack in qede_flow_parse_tcp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 07/14] net: qede: use extack in qede_flow_parse_tcp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:28   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 08/14] net: qede: use extack in qede_flow_parse_udp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 09/14] net: qede: use extack in qede_flow_parse_udp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:29   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 10/14] net: qede: add extack in qede_add_tc_flower_fltr() Asbjørn Sloth Tønnesen
2024-05-10 11:29   ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 11/14] net: qede: use extack in qede_parse_flow_attr() Asbjørn Sloth Tønnesen
2024-05-10 11:29   ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 12/14] net: qede: use faked extack in qede_flow_spec_to_rule() Asbjørn Sloth Tønnesen
2024-05-10 11:30   ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 13/14] net: qede: propagate extack through qede_flow_spec_validate() Asbjørn Sloth Tønnesen
2024-05-10 11:30   ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions() Asbjørn Sloth Tønnesen
2024-05-10 11:31   ` Simon Horman
2024-05-10 11:25 ` [PATCH net-next v2 00/14] net: qede: convert filter code to use extack Simon Horman
2024-05-11  2:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508143404.95901-1-ast@fiberby.net \
    --to=ast@fiberby.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox