From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Manish Chopra" <manishc@marvell.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>
Subject: [PATCH net-next v2 03/14] net: qede: use extack in qede_set_v4_tuple_to_profile()
Date: Wed, 8 May 2024 14:33:51 +0000 [thread overview]
Message-ID: <20240508143404.95901-4-ast@fiberby.net> (raw)
In-Reply-To: <20240508143404.95901-1-ast@fiberby.net>
Convert qede_set_v4_tuple_to_profile() to take extack,
and drop the edev argument.
Convert DP_INFO call to use NL_SET_ERR_MSG_MOD instead.
In calls to qede_set_v4_tuple_to_profile(), use NULL as extack
for now, until a subsequent patch makes extack available.
Only compile tested.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/ethernet/qlogic/qede/qede_filter.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index 0f951d00b10e..6f4c4a5d6c77 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -1520,8 +1520,8 @@ static int qede_flow_spec_validate_unused(struct qede_dev *edev,
return 0;
}
-static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
- struct qede_arfs_tuple *t)
+static int qede_set_v4_tuple_to_profile(struct qede_arfs_tuple *t,
+ struct netlink_ext_ack *extack)
{
/* We must have Only 4-tuples/l4 port/src ip/dst ip
* as an input.
@@ -1538,7 +1538,7 @@ static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
t->dst_ipv4 && !t->src_ipv4) {
t->mode = QED_FILTER_CONFIG_MODE_IP_DEST;
} else {
- DP_INFO(edev, "Invalid N-tuple\n");
+ NL_SET_ERR_MSG_MOD(extack, "Invalid N-tuple");
return -EOPNOTSUPP;
}
@@ -1779,7 +1779,7 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
if (err)
return err;
- return qede_set_v4_tuple_to_profile(edev, t);
+ return qede_set_v4_tuple_to_profile(t, NULL);
}
static int
--
2.43.0
next prev parent reply other threads:[~2024-05-08 14:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 14:33 [PATCH net-next v2 00/14] net: qede: convert filter code to use extack Asbjørn Sloth Tønnesen
2024-05-08 14:33 ` [PATCH net-next v2 01/14] net: qede: use extack in qede_flow_parse_ports() Asbjørn Sloth Tønnesen
2024-05-10 11:26 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 02/14] net: qede: use extack in qede_set_v6_tuple_to_profile() Asbjørn Sloth Tønnesen
2024-05-10 11:26 ` Simon Horman
2024-05-08 14:33 ` Asbjørn Sloth Tønnesen [this message]
2024-05-10 11:27 ` [PATCH net-next v2 03/14] net: qede: use extack in qede_set_v4_tuple_to_profile() Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 04/14] net: qede: use extack in qede_flow_parse_v6_common() Asbjørn Sloth Tønnesen
2024-05-10 11:27 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 05/14] net: qede: use extack in qede_flow_parse_v4_common() Asbjørn Sloth Tønnesen
2024-05-10 11:27 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 06/14] net: qede: use extack in qede_flow_parse_tcp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 07/14] net: qede: use extack in qede_flow_parse_tcp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 08/14] net: qede: use extack in qede_flow_parse_udp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 09/14] net: qede: use extack in qede_flow_parse_udp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 10/14] net: qede: add extack in qede_add_tc_flower_fltr() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 11/14] net: qede: use extack in qede_parse_flow_attr() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 12/14] net: qede: use faked extack in qede_flow_spec_to_rule() Asbjørn Sloth Tønnesen
2024-05-10 11:30 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 13/14] net: qede: propagate extack through qede_flow_spec_validate() Asbjørn Sloth Tønnesen
2024-05-10 11:30 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions() Asbjørn Sloth Tønnesen
2024-05-10 11:31 ` Simon Horman
2024-05-10 11:25 ` [PATCH net-next v2 00/14] net: qede: convert filter code to use extack Simon Horman
2024-05-11 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508143404.95901-4-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox