From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Manish Chopra" <manishc@marvell.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>
Subject: [PATCH net-next v2 05/14] net: qede: use extack in qede_flow_parse_v4_common()
Date: Wed, 8 May 2024 14:33:53 +0000 [thread overview]
Message-ID: <20240508143404.95901-6-ast@fiberby.net> (raw)
In-Reply-To: <20240508143404.95901-1-ast@fiberby.net>
Convert qede_flow_parse_v4_common() to take extack,
and drop the edev argument.
Convert DP_NOTICE call to use NL_SET_ERR_MSG_MOD instead.
Pass extack in calls to qede_flow_parse_ports() and
qede_set_v4_tuple_to_profile().
In calls to qede_flow_parse_v4_common(), use NULL as extack
for now, until a subsequent patch makes extack available.
Only compile tested.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/ethernet/qlogic/qede/qede_filter.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index f5f8bbe8a64c..28e4d54dbca1 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -1757,8 +1757,9 @@ qede_flow_parse_v6_common(struct flow_rule *rule,
}
static int
-qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
- struct qede_arfs_tuple *t)
+qede_flow_parse_v4_common(struct flow_rule *rule,
+ struct qede_arfs_tuple *t,
+ struct netlink_ext_ack *extack)
{
int err;
@@ -1768,7 +1769,8 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
flow_rule_match_ipv4_addrs(rule, &match);
if ((match.key->src && match.mask->src != htonl(U32_MAX)) ||
(match.key->dst && match.mask->dst != htonl(U32_MAX))) {
- DP_NOTICE(edev, "Do not support ipv4 prefix/masks\n");
+ NL_SET_ERR_MSG_MOD(extack,
+ "Do not support ipv4 prefix/masks");
return -EINVAL;
}
@@ -1776,11 +1778,11 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
t->dst_ipv4 = match.key->dst;
}
- err = qede_flow_parse_ports(rule, t, NULL);
+ err = qede_flow_parse_ports(rule, t, extack);
if (err)
return err;
- return qede_set_v4_tuple_to_profile(t, NULL);
+ return qede_set_v4_tuple_to_profile(t, extack);
}
static int
@@ -1800,7 +1802,7 @@ qede_flow_parse_tcp_v4(struct qede_dev *edev, struct flow_rule *rule,
tuple->ip_proto = IPPROTO_TCP;
tuple->eth_proto = htons(ETH_P_IP);
- return qede_flow_parse_v4_common(edev, rule, tuple);
+ return qede_flow_parse_v4_common(rule, tuple, NULL);
}
static int
@@ -1820,7 +1822,7 @@ qede_flow_parse_udp_v4(struct qede_dev *edev, struct flow_rule *rule,
tuple->ip_proto = IPPROTO_UDP;
tuple->eth_proto = htons(ETH_P_IP);
- return qede_flow_parse_v4_common(edev, rule, tuple);
+ return qede_flow_parse_v4_common(rule, tuple, NULL);
}
static int
--
2.43.0
next prev parent reply other threads:[~2024-05-08 14:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 14:33 [PATCH net-next v2 00/14] net: qede: convert filter code to use extack Asbjørn Sloth Tønnesen
2024-05-08 14:33 ` [PATCH net-next v2 01/14] net: qede: use extack in qede_flow_parse_ports() Asbjørn Sloth Tønnesen
2024-05-10 11:26 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 02/14] net: qede: use extack in qede_set_v6_tuple_to_profile() Asbjørn Sloth Tønnesen
2024-05-10 11:26 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 03/14] net: qede: use extack in qede_set_v4_tuple_to_profile() Asbjørn Sloth Tønnesen
2024-05-10 11:27 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 04/14] net: qede: use extack in qede_flow_parse_v6_common() Asbjørn Sloth Tønnesen
2024-05-10 11:27 ` Simon Horman
2024-05-08 14:33 ` Asbjørn Sloth Tønnesen [this message]
2024-05-10 11:27 ` [PATCH net-next v2 05/14] net: qede: use extack in qede_flow_parse_v4_common() Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 06/14] net: qede: use extack in qede_flow_parse_tcp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 07/14] net: qede: use extack in qede_flow_parse_tcp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 08/14] net: qede: use extack in qede_flow_parse_udp_v6() Asbjørn Sloth Tønnesen
2024-05-10 11:28 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 09/14] net: qede: use extack in qede_flow_parse_udp_v4() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 10/14] net: qede: add extack in qede_add_tc_flower_fltr() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:33 ` [PATCH net-next v2 11/14] net: qede: use extack in qede_parse_flow_attr() Asbjørn Sloth Tønnesen
2024-05-10 11:29 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 12/14] net: qede: use faked extack in qede_flow_spec_to_rule() Asbjørn Sloth Tønnesen
2024-05-10 11:30 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 13/14] net: qede: propagate extack through qede_flow_spec_validate() Asbjørn Sloth Tønnesen
2024-05-10 11:30 ` Simon Horman
2024-05-08 14:34 ` [PATCH net-next v2 14/14] net: qede: use extack in qede_parse_actions() Asbjørn Sloth Tønnesen
2024-05-10 11:31 ` Simon Horman
2024-05-10 11:25 ` [PATCH net-next v2 00/14] net: qede: convert filter code to use extack Simon Horman
2024-05-11 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508143404.95901-6-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox