Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support

Markus Elfring
2024-05-08T14:09:26Z

…
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
…
> +static int gve_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, u32 *rule_locs)
> +{
> + struct gve_priv *priv = netdev_priv(netdev);
> + int err = 0;
> +
> + dev_hold(netdev);
> + rtnl_unlock();
…
> +out:
> + rtnl_lock();
> + dev_put(netdev);
> + return err;
> +}
…

How do you think about to increase the application of scope-based resource management
at such source code places?

Regards,
Markus