* [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'
@ 2024-05-11 14:52 linux
2024-05-25 0:07 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: linux @ 2024-05-11 14:52 UTC (permalink / raw)
To: gilad, herbert; +Cc: linux-crypto, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'tdes_keys' appears unused.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/crypto/ccree/cc_cipher.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
index cd66a580e8b64..3fb667a17bbb1 100644
--- a/drivers/crypto/ccree/cc_cipher.c
+++ b/drivers/crypto/ccree/cc_cipher.c
@@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
kfree_sensitive(ctx_p->user.key);
}
-struct tdes_keys {
- u8 key1[DES_KEY_SIZE];
- u8 key2[DES_KEY_SIZE];
- u8 key3[DES_KEY_SIZE];
-};
-
static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
{
switch (slot_num) {
--
2.45.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'
2024-05-11 14:52 [PATCH] crypto: ccree: Remove unused struct 'tdes_keys' linux
@ 2024-05-25 0:07 ` Dr. David Alan Gilbert
2024-05-27 12:58 ` Gilad Ben-Yossef
2024-05-31 9:57 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2024-05-25 0:07 UTC (permalink / raw)
To: gilad, herbert; +Cc: davem, linux-crypto, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping.
> ---
> drivers/crypto/ccree/cc_cipher.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
> kfree_sensitive(ctx_p->user.key);
> }
>
> -struct tdes_keys {
> - u8 key1[DES_KEY_SIZE];
> - u8 key2[DES_KEY_SIZE];
> - u8 key3[DES_KEY_SIZE];
> -};
> -
> static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
> {
> switch (slot_num) {
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'
2024-05-11 14:52 [PATCH] crypto: ccree: Remove unused struct 'tdes_keys' linux
2024-05-25 0:07 ` Dr. David Alan Gilbert
@ 2024-05-27 12:58 ` Gilad Ben-Yossef
2024-05-31 9:57 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Gilad Ben-Yossef @ 2024-05-27 12:58 UTC (permalink / raw)
To: linux; +Cc: herbert, linux-crypto, linux-kernel
Hi David,
On Sat, May 11, 2024 at 5:52 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Thank you for the patch and your patience.
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/crypto/ccree/cc_cipher.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_cipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
> kfree_sensitive(ctx_p->user.key);
> }
>
> -struct tdes_keys {
> - u8 key1[DES_KEY_SIZE];
> - u8 key2[DES_KEY_SIZE];
> - u8 key3[DES_KEY_SIZE];
> -};
> -
> static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
> {
> switch (slot_num) {
> --
> 2.45.0
>
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'
2024-05-11 14:52 [PATCH] crypto: ccree: Remove unused struct 'tdes_keys' linux
2024-05-25 0:07 ` Dr. David Alan Gilbert
2024-05-27 12:58 ` Gilad Ben-Yossef
@ 2024-05-31 9:57 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2024-05-31 9:57 UTC (permalink / raw)
To: linux; +Cc: gilad, linux-crypto, linux-kernel
On Sat, May 11, 2024 at 03:52:00PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/crypto/ccree/cc_cipher.c | 6 ------
> 1 file changed, 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-31 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-11 14:52 [PATCH] crypto: ccree: Remove unused struct 'tdes_keys' linux
2024-05-25 0:07 ` Dr. David Alan Gilbert
2024-05-27 12:58 ` Gilad Ben-Yossef
2024-05-31 9:57 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox