Re: [PATCH net] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()

Simon Horman
2024-05-16T12:03:36Z

On Thu, May 16, 2024 at 06:24:54PM +0900, Ryosuke Yasuoka wrote:
> Thank you for your review and comment, Simon.
>
> On Thu, May 16, 2024 at 09:43:48AM +0100, Simon Horman wrote:
> > Hi Yasuoka-san,
> >
> > On Thu, May 16, 2024 at 12:17:07AM +0900, Ryosuke Yasuoka wrote:
> > > When nci_rx_work() receives a zero-length payload packet, it should
> > > discard the packet without exiting the loop. Instead, it should continue
> > > processing subsequent packets.
> >
> > nit: I think it would be clearer to say:
> >
> > ... it should not discard the packet and exit the loop. Instead, ...
>
> Great. I'll update commit msg like this.
>
> > >
> > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
> > > Closes: https://lore.kernel.org/lkml/20240428134525.GW516117@kernel.org/T/
> >
> > nit: I'm not sure this Closes link is adding much,
> > there are more changes coming, right?
>
> No. I just wanna show the URL link as a reference where this bug is
> found. This URL discuss a little bit different topic as you know.
>
> In the following discussion [1], Jakub pointed out that changing
> continue statement to break is not related to the patch "Fix
> uninit-value in nci_rw_work". So I posted this new small patch before
> posting v5 patch for "Fix: uninit-value in nci_rw_work".
>
> If Closes tag is not appropriate, I can remove this in this v2 patch.
> What do you think?

Thanks, if it was me I would drop the Closes tag.

> [1] https://lore.kernel.org/all/20240510190613.72838bf0@kernel.org/

...