public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] mtd: nand: mxc_nand: implement exec_op
Date: Thu, 16 May 2024 10:32:14 +0200	[thread overview]
Message-ID: <20240516103214.57a8ce33@xps-13> (raw)
In-Reply-To: <20240514-mtd-nand-mxc-nand-exec-op-v3-2-3e6f45fd3d82@pengutronix.de>

Hi Sascha,

> +static const struct nand_op_parser mxcnd_op_parser = NAND_OP_PARSER(
> +	NAND_OP_PARSER_PATTERN(mxcnd_do_exec_op,
> +			       NAND_OP_PARSER_PAT_CMD_ELEM(false),
> +			       NAND_OP_PARSER_PAT_ADDR_ELEM(true, 7),
> +			       NAND_OP_PARSER_PAT_CMD_ELEM(true),
> +			       NAND_OP_PARSER_PAT_WAITRDY_ELEM(true),
> +			       NAND_OP_PARSER_PAT_DATA_IN_ELEM(true, MAX_DATA_SIZE)),

CMD, ADDR, CMD, DATA is the RNDOUT pattern. So it is now working fine?
Or did you forget to adapt the patterns to your use case?


Thanks,
Miquèl

  reply	other threads:[~2024-05-16  8:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 14:25 [PATCH v3 0/3] mtd: nand: mxc_nand: Convert to exec_op Sascha Hauer
2024-05-14 14:25 ` [PATCH v3 1/3] mtd: nand: mxc_nand: separate page read from ecc calc Sascha Hauer
2024-05-14 14:25 ` [PATCH v3 2/3] mtd: nand: mxc_nand: implement exec_op Sascha Hauer
2024-05-16  8:32   ` Miquel Raynal [this message]
2024-05-16 10:25     ` Sascha Hauer
2024-05-16 10:44       ` Miquel Raynal
2024-05-16 11:36         ` Sascha Hauer
2024-05-16 13:05           ` Miquel Raynal
2024-05-14 14:25 ` [PATCH v3 3/3] mtd: nand: mxc_nand: support software ECC Sascha Hauer
2024-05-15  8:29   ` Sascha Hauer
2024-05-16  8:33     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516103214.57a8ce33@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=s.hauer@pengutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox