Re: [PATCH 08/16] KVM: x86/mmu: Bug the VM if kvm_zap_gfn_range() is called for TDX

Huang, Kai
2024-05-15T23:15:08Z

On 16/05/2024 3:22 am, Edgecombe, Rick P wrote:
> On Wed, 2024-05-15 at 13:27 +0000, Huang, Kai wrote:
>>
>> kvm_zap_gfn_range() looks a generic function.  I think it makes more sense
>> to let the callers to explicitly check whether VM is TDX guest and do the
>> KVM_BUG_ON()?
>
> Other TDX changes will prevent this function getting called. So basically like
> you are suggesting. This change is to catch any new cases that pop up, which we
> can't do at the caller.

But I think we need to see whether calling kvm_zap_gfn_range() is legal
or not for TDX guest case by case, but not having a universal rule that
this cannot be called for TDX guest, right?