From: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Dimitri Fedrau <dima.fedrau@gmail.com>,
Andrew Hepp <andrew.hepp@ahepp.dev>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] iio: temperature: mcp9600: Provide index for both channels
Date: Fri, 17 May 2024 10:10:49 +0200 [thread overview]
Message-ID: <20240517081050.168698-2-dima.fedrau@gmail.com> (raw)
In-Reply-To: <20240517081050.168698-1-dima.fedrau@gmail.com>
The mapping from cold junction to ambient temperature is inaccurate. We
provide an index for hot and cold junction temperatures.
Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
---
drivers/iio/temperature/mcp9600.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mcp9600.c
index 46845804292b..22451d1d9e1f 100644
--- a/drivers/iio/temperature/mcp9600.c
+++ b/drivers/iio/temperature/mcp9600.c
@@ -14,6 +14,9 @@
#include <linux/iio/iio.h>
+#define MCP9600_CHAN_HOT_JUNCTION 0
+#define MCP9600_CHAN_COLD_JUNCTION 1
+
/* MCP9600 registers */
#define MCP9600_HOT_JUNCTION 0x0
#define MCP9600_COLD_JUNCTION 0x2
@@ -25,17 +28,19 @@
static const struct iio_chan_spec mcp9600_channels[] = {
{
.type = IIO_TEMP,
+ .channel = MCP9600_CHAN_HOT_JUNCTION,
.address = MCP9600_HOT_JUNCTION,
.info_mask_separate =
BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
+ .indexed = 1,
},
{
.type = IIO_TEMP,
+ .channel = MCP9600_CHAN_COLD_JUNCTION,
.address = MCP9600_COLD_JUNCTION,
- .channel2 = IIO_MOD_TEMP_AMBIENT,
- .modified = 1,
.info_mask_separate =
BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
+ .indexed = 1,
},
};
--
2.39.2
next prev parent reply other threads:[~2024-05-17 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 8:10 [PATCH v2 0/2] Add threshold events support Dimitri Fedrau
2024-05-17 8:10 ` Dimitri Fedrau [this message]
2024-05-17 15:30 ` [PATCH v2 1/2] iio: temperature: mcp9600: Provide index for both channels Markus Elfring
2024-05-19 16:14 ` Jonathan Cameron
2024-05-19 20:32 ` Dimitri Fedrau
2024-05-20 12:17 ` Jonathan Cameron
2024-05-21 2:28 ` Andrew Hepp
2024-05-23 11:21 ` Dimitri Fedrau
2024-05-17 8:10 ` [PATCH v2 2/2] iio: temperature: mcp9600: add threshold events support Dimitri Fedrau
2024-05-19 16:42 ` Jonathan Cameron
2024-05-19 21:00 ` Dimitri Fedrau
2024-05-20 12:18 ` Jonathan Cameron
2024-05-23 11:14 ` Dimitri Fedrau
2024-05-17 13:28 ` [PATCH v2 0/2] Add " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517081050.168698-2-dima.fedrau@gmail.com \
--to=dima.fedrau@gmail.com \
--cc=andrew.hepp@ahepp.dev \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox