Re: [PATCH 04/16] KVM: x86/mmu: Add address conversion functions for TDX shared bit of GPA

Edgecombe, Rick P
2024-05-16T00:19:28Z

On Thu, 2024-05-16 at 12:12 +1200, Huang, Kai wrote:
>
> I don't have strong objection if the use of kvm_gfn_shared_mask() is
> contained in smaller areas that truly need it.  Let's discuss in
> relevant patch(es).
>
> However I do think the helpers like below makes no sense (for SEV-SNP):
>
> +static inline bool kvm_is_private_gpa(const struct kvm *kvm, gpa_t gpa)
> +{
> +       gfn_t mask = kvm_gfn_shared_mask(kvm);
> +
> +       return mask && !(gpa_to_gfn(gpa) & mask);
> +}

You mean the name? SNP doesn't have a concept of "private GPA" IIUC. The C bit
is more like an permission bit. So SNP doesn't have private GPAs, and the
function would always return false for SNP. So I'm not sure it's too horrible.

If it's the name, can you suggest something?