Re: [PATCH net-next 3/4] vmxnet3: add command to allow disabling of offloads

Simon Horman
2024-05-15T10:47:44Z

On Tue, May 14, 2024 at 11:20:48AM -0700, Ronak Doshi wrote:
> This patch adds a new command to disable certain offloads. This
> allows user to specify, using VM configuration, if certain offloads
> need to be disabled.
>
> Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
> Acked-by: Guolin Yang <guolin.yang@broadcom.com>

...

> @@ -912,4 +913,7 @@ struct Vmxnet3_DriverShared {
> /* when new capability is introduced, update VMXNET3_CAP_MAX */
> #define VMXNET3_CAP_MAX VMXNET3_CAP_VERSION_7_MAX
>
> +#define VMXNET3_OFFLOAD_TSO (1 << 0)
> +#define VMXNET3_OFFLOAD_LRO (1 << 1)

nit: Please consider using the BIT() macro.

...