Re: [PATCH RFCv1 02/14] iommufd: Swap _iommufd_object_alloc and __iommufd_object_alloc

Nicolin Chen
2024-05-13T03:44:49Z

On Sun, May 12, 2024 at 07:29:54PM -0700, Nicolin Chen wrote:
> On Sun, May 12, 2024 at 10:26:44AM -0300, Jason Gunthorpe wrote:
> > On Fri, Apr 12, 2024 at 08:46:59PM -0700, Nicolin Chen wrote:
> > > Currently, the object allocation function calls:
> > > level-0: iommufd_object_alloc()
> > > level-1: ___iommufd_object_alloc()
> > > level-2: _iommufd_object_alloc()
> >
> > Let's give __iommufd_object_alloc() a better name then
> >
> > It is a less general version of iommufd_object_alloc(), maybe
> > iommufd_object_alloc_elm() ?
>
> With the level-3 allocator, something like the followings?
>
> level-0: iommufd_object_alloc()
> level-1: __iommufd_object_alloc()
> level-2: iommufd_object_alloc_elm()
> level-3: __iommufd_object_alloc_elm()
>
> In this case, this patch will be:
> "iommufd: Rename _iommufd_object_alloc to iommufd_object_alloc_elm"

After reading your comments in PATCH-4, seems that we don't need
the level-3 allocator, if we pass an ictx pointer throughout the
core and driver. I will try with this first.

Thanks
Nicolin