From: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
To: akpm@linux-foundation.org
Cc: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen.n.rao@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, julia.lawall@inria.fr,
javier.carrasco.cruz@gmail.com,
Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
Subject: [PATCH next] arch: powerpc: platforms: Remove unnecessary call to of_node_get
Date: Thu, 23 May 2024 01:12:50 +0530 [thread overview]
Message-ID: <20240522194250.1165568-1-pvkumar5749404@gmail.com> (raw)
`dev->of_node` has a pointer to device node, of_node_get call seems
unnecessary.
It will automate the cleanup process allowing to remove the of_node_put
call.
Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com>
---
arch/powerpc/platforms/cell/iommu.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
index 4cd9c0de22c2..5b794ce08689 100644
--- a/arch/powerpc/platforms/cell/iommu.c
+++ b/arch/powerpc/platforms/cell/iommu.c
@@ -780,14 +780,13 @@ static int __init cell_iommu_init_disabled(void)
static u64 cell_iommu_get_fixed_address(struct device *dev)
{
u64 cpu_addr, size, best_size, dev_addr = OF_BAD_ADDR;
- struct device_node *np;
+ struct device_node *np = dev->of_node;
const u32 *ranges = NULL;
int i, len, best, naddr, nsize, pna, range_size;
/* We can be called for platform devices that have no of_node */
- np = of_node_get(dev->of_node);
if (!np)
- goto out;
+ return dev_addr;
while (1) {
naddr = of_n_addr_cells(np);
@@ -805,7 +804,7 @@ static u64 cell_iommu_get_fixed_address(struct device *dev)
if (!ranges) {
dev_dbg(dev, "iommu: no dma-ranges found\n");
- goto out;
+ return dev_addr;
}
len /= sizeof(u32);
@@ -833,8 +832,6 @@ static u64 cell_iommu_get_fixed_address(struct device *dev)
} else
dev_dbg(dev, "iommu: no suitable range found!\n");
-out:
- of_node_put(np);
return dev_addr;
}
--
2.34.1
next reply other threads:[~2024-05-22 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 19:42 Prabhav Kumar Vaish [this message]
2024-05-23 11:25 ` [PATCH next] arch: powerpc: platforms: Remove unnecessary call to of_node_get Michael Ellerman
2024-05-23 18:01 ` prabhav kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522194250.1165568-1-pvkumar5749404@gmail.com \
--to=pvkumar5749404@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox