[PATCH 0/3] IIO dead struct cleanup

[PATCH 0/3] IIO dead struct cleanup

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  Three dead structs to cleanup in iio.
The bmi and pac are very recent.

(Build tested only)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>


Dr. David Alan Gilbert (3):
  iio: accel: bmi088: remove unused struct 'bmi088_scale_info'
  iio: adc: pac1934: remove unused struct 'samp_rate_mapping'
  iio: light: rohm-bu27034: remove unused struct 'bu27034_result'

 drivers/iio/accel/bmi088-accel-core.c | 5 -----
 drivers/iio/adc/pac1934.c             | 5 -----
 drivers/iio/light/rohm-bu27034.c      | 6 ------
 3 files changed, 16 deletions(-)

-- 
2.45.1

[PATCH 1/3] iio: accel: bmi088: remove unused struct 'bmi088_scale_info'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'bmi088_scale_info' has been unused since the original
commit c19ae6be7555 ("iio: accel: Add support for the Bosch-Sensortec
BMI088").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/iio/accel/bmi088-accel-core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c
index 4d989708e6c3..469a1255d93c 100644
--- a/drivers/iio/accel/bmi088-accel-core.c
+++ b/drivers/iio/accel/bmi088-accel-core.c
@@ -114,11 +114,6 @@ enum bmi088_odr_modes {
 	BMI088_ACCEL_MODE_ODR_1600 = 0xc,
 };
 
-struct bmi088_scale_info {
-	int scale;
-	u8 reg_range;
-};
-
 struct bmi088_accel_chip_info {
 	const char *name;
 	u8 chip_id;
-- 
2.45.1

[PATCH 2/3] iio: adc: pac1934: remove unused struct 'samp_rate_mapping'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'samp_rate_mapping' has been unused since the original
commit 0fb528c8255b ("iio: adc: adding support for PAC193x").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/iio/adc/pac1934.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
index 456f12faa348..ae24a27805ab 100644
--- a/drivers/iio/adc/pac1934.c
+++ b/drivers/iio/adc/pac1934.c
@@ -227,11 +227,6 @@ struct pac1934_features {
 	const char	*name;
 };
 
-struct samp_rate_mapping {
-	u16 samp_rate;
-	u8 shift2value;
-};
-
 static const unsigned int samp_rate_map_tbl[] = {
 	[PAC1934_SAMP_1024SPS] = 1024,
 	[PAC1934_SAMP_256SPS] = 256,
-- 
2.45.1

[PATCH 3/3] iio: light: rohm-bu27034: remove unused struct 'bu27034_result'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'bu27034_result' is unused since the original
commit e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/iio/light/rohm-bu27034.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27034.c
index bf3de853a811..4937bf6fa046 100644
--- a/drivers/iio/light/rohm-bu27034.c
+++ b/drivers/iio/light/rohm-bu27034.c
@@ -223,12 +223,6 @@ struct bu27034_data {
 	} scan;
 };
 
-struct bu27034_result {
-	u16 ch0;
-	u16 ch1;
-	u16 ch2;
-};
-
 static const struct regmap_range bu27034_volatile_ranges[] = {
 	{
 		.range_min = BU27034_REG_SYSTEM_CONTROL,
-- 
2.45.1

Re: [PATCH 3/3] iio: light: rohm-bu27034: remove unused struct 'bu27034_result'

[Matti Vaittinen]

Thanks David!

On 5/23/24 02:04, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'bu27034_result' is unused since the original
> commit e52afbd61039 ("iio: light: ROHM BU27034 Ambient Light Sensor").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

As I wrote earlier, this driver in it's current form is pretty much 
useless. The BU27034NUC was cancelled and, as far as I know, never 
produced "en masse". The replacement, BU27034ANUC, has undergone 
somewhat meaningful changes like removal of one of the data channels - 
so this driver is not producing correct results on that IC.

I have promised to rework this driver to support the new variant, and I 
have this new HW on my table - but I am currently negotiating to be able 
to provide an open-source Lux calculation formula in the driver... This 
is causing some slight delay.

So, I think applying this patch is still worth :)

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/iio/light/rohm-bu27034.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27034.c
> index bf3de853a811..4937bf6fa046 100644
> --- a/drivers/iio/light/rohm-bu27034.c
> +++ b/drivers/iio/light/rohm-bu27034.c
> @@ -223,12 +223,6 @@ struct bu27034_data {
>   	} scan;
>   };
>   
> -struct bu27034_result {
> -	u16 ch0;
> -	u16 ch1;
> -	u16 ch2;
> -};
> -
>   static const struct regmap_range bu27034_volatile_ranges[] = {
>   	{
>   		.range_min = BU27034_REG_SYSTEM_CONTROL,

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: [PATCH 0/3] IIO dead struct cleanup

[Jonathan Cameron]

On Thu, 23 May 2024 00:04:54 +0100
linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Hi,
>   Three dead structs to cleanup in iio.
> The bmi and pac are very recent.
> 
> (Build tested only)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> 
Series applied,

Thanks,

Jonathan

> Dr. David Alan Gilbert (3):
>   iio: accel: bmi088: remove unused struct 'bmi088_scale_info'
>   iio: adc: pac1934: remove unused struct 'samp_rate_mapping'
>   iio: light: rohm-bu27034: remove unused struct 'bu27034_result'
> 
>  drivers/iio/accel/bmi088-accel-core.c | 5 -----
>  drivers/iio/adc/pac1934.c             | 5 -----
>  drivers/iio/light/rohm-bu27034.c      | 6 ------
>  3 files changed, 16 deletions(-)
>