From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: [PATCH v2 0/4] tracefs/eventfs: Fix failed second run of test_ownership
Date: Thu, 23 May 2024 01:14:25 -0400 [thread overview]
Message-ID: <20240523051425.335105631@goodmis.org> (raw)
The test_ownership test of the kselftests was failing again.
That's because the original fix was incorrect and a fix to
a race condition showed how the original fix was broken.
Instead of using tracefs_inodes to find the eventfs_inode that
needs to be reset on remount, use the "events" directory descriptor
to descend into its files and directories to catch all changes.
Changes since v1: https://lore.kernel.org/linux-trace-kernel/20240522124504.28982867@gandalf.local.home
- Added other fixes underneath and rebased it on:
https://lore.kernel.org/lkml/20240522164320.469785149@goodmis.org/
- The real fix is to not use the tracefs_inodes to find the eventfs_inodes
that need to be cleared on remount. Instead, the events descriptor
needs to be used to descend its directories and files to update
their attributes
- The d_iput callback logic was misplaced. It should be done in the
drop_inode callback.
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
eventfs/urgent
Head SHA1: 41b7db11bcac4638fa489c58d35e7d2146b665ab
Steven Rostedt (Google) (4):
eventfs: Keep the directories from having the same inode number as files
tracefs: Update inode permissions on remount
eventfs: Update all the eventfs_inodes from the events descriptor
tracefs: Clear EVENT_INODE flag in tracefs_drop_inode()
----
fs/tracefs/event_inode.c | 57 +++++++++++++++++++++++++++++++++++++-----------
fs/tracefs/inode.c | 48 ++++++++++++++++++++++++----------------
2 files changed, 73 insertions(+), 32 deletions(-)
next reply other threads:[~2024-05-23 5:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 5:14 Steven Rostedt [this message]
2024-05-23 5:14 ` [PATCH v2 1/4] eventfs: Keep the directories from having the same inode number as files Steven Rostedt
2024-05-23 5:14 ` [PATCH v2 2/4] tracefs: Update inode permissions on remount Steven Rostedt
2024-05-23 5:14 ` [PATCH v2 3/4] eventfs: Update all the eventfs_inodes from the events descriptor Steven Rostedt
2024-05-23 5:14 ` [PATCH v2 4/4] tracefs: Clear EVENT_INODE flag in tracefs_drop_inode() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523051425.335105631@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox