From: Christoph Hellwig <hch@lst.de>
To: John Meneghini <jmeneghi@redhat.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
emilne@redhat.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, jrani@purestorage.com,
randyj@purestorage.com, hare@kernel.org
Subject: Re: [PATCH v5] nvme: multipath: Implemented new iopolicy "queue-depth"
Date: Thu, 23 May 2024 10:14:43 +0200 [thread overview]
Message-ID: <20240523081443.GD1086@lst.de> (raw)
In-Reply-To: <20240522165406.702362-1-jmeneghi@redhat.com>
Oh, and there is really something of with the patch format.
First the subject line is completely wrong, this should be:
nvme-multipath: implement "queue-depth" iopolicy.
On Wed, May 22, 2024 at 12:54:06PM -0400, John Meneghini wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
> Signed-off-by: Thomas Song <tsong@purestorage.com>
> [emilne: patch developed by Thomas Song @ Pure Storage, fixed whitespace
> and compilation warnings, updated MODULE_PARM description, and
> fixed potential issue with ->current_path[] being used]
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Second the patch author needs to be the first signoff. I'm not entirely
sure who is supposed to be the author, but either it should be Thomas,
or if the patch has changed so much that it's someone else the original
signoff should turn into a Co-Developed-by.
next prev parent reply other threads:[~2024-05-23 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 16:54 [PATCH v5] nvme: multipath: Implemented new iopolicy "queue-depth" John Meneghini
2024-05-22 17:32 ` Keith Busch
2024-05-23 6:45 ` Christoph Hellwig
2024-05-23 13:12 ` John Meneghini
2024-05-23 13:16 ` Christoph Hellwig
2024-05-23 13:33 ` John Meneghini
2024-05-23 15:56 ` Keith Busch
2024-05-23 3:00 ` John Meneghini
2024-05-23 4:29 ` Chaitanya Kulkarni
2024-05-23 6:28 ` Hannes Reinecke
2024-05-23 13:42 ` John Meneghini
2024-05-23 19:33 ` Chaitanya Kulkarni
2024-05-23 19:28 ` Chaitanya Kulkarni
2024-05-23 6:52 ` Christoph Hellwig
2024-05-23 15:08 ` John Meneghini
2024-05-23 8:14 ` Christoph Hellwig [this message]
2024-05-23 16:07 ` John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523081443.GD1086@lst.de \
--to=hch@lst.de \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox