Re: [PATCH 0/3 v2] seccomp: improve handling of SECCOMP_IOCTL_NOTIF_RECV

Andrei Vagin
2024-06-25T00:17:21Z

Kees,

Are you waiting for anything from me? I think this series is ready to be merged.

Thanks,
Andrei

On Wed, May 22, 2024 at 6:45 PM Andrei Vagin <avagin@google.com> wrote:
>
> This patch set addresses two problems with the SECCOMP_IOCTL_NOTIF_RECV
> ioctl:
> * it doesn't return when the seccomp filter becomes unused (all tasks
> have exited).
> * EPOLLHUP is triggered not when a task exits, but rather when its zombie
> is collected.
>
> v2: - Remove unnecessary checks of PF_EXITING.
> - Take siglock with disabling irqs.
> Thanks to Oleg for the review and the help with the first version.
>
> Andrei Vagin (3):
> seccomp: interrupt SECCOMP_IOCTL_NOTIF_RECV when all users have exited
> seccomp: release task filters when the task exits
> selftests/seccomp: add test for NOTIF_RECV and unused filters
>
> kernel/exit.c | 3 +-
> kernel/seccomp.c | 38 ++++++++++---
> tools/testing/selftests/seccomp/seccomp_bpf.c | 54 +++++++++++++++++++
> 3 files changed, 88 insertions(+), 7 deletions(-)
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Will Drewry <wad@chromium.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Tycho Andersen <tandersen@netflix.com>
>
>
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog
>