public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes
@ 2024-05-23 19:44 Rob Herring (Arm)
  2024-05-23 21:21 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-05-23 19:44 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Krzysztof Kozlowski, Conor Dooley,
	Matthias Kaehlcke, Stephen Boyd
  Cc: linux-usb, devicetree, linux-kernel

All nodes need an explicit additionalProperties or unevaluatedProperties
unless a $ref has one that's false. As that is not the case with
usb-device.yaml, "additionalProperties" is needed here.

Fixes: c44d9dab31d6 ("dt-bindings: usb: Add downstream facing ports to realtek binding")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/usb/realtek,rts5411.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
index 0874fc21f66f..6577a61cc075 100644
--- a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
+++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
@@ -65,6 +65,7 @@ patternProperties:
     description: The hard wired USB devices
     type: object
     $ref: /schemas/usb/usb-device.yaml
+    additionalProperties: true
 
 required:
   - peer-hub
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes
  2024-05-23 19:44 [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes Rob Herring (Arm)
@ 2024-05-23 21:21 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2024-05-23 21:21 UTC (permalink / raw)
  To: Conor Dooley, Greg Kroah-Hartman, Krzysztof Kozlowski,
	Matthias Kaehlcke, Rob Herring
  Cc: linux-usb, devicetree, linux-kernel

Quoting Rob Herring (Arm) (2024-05-23 12:44:59)
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false. As that is not the case with
> usb-device.yaml, "additionalProperties" is needed here.
>
> Fixes: c44d9dab31d6 ("dt-bindings: usb: Add downstream facing ports to realtek binding")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-23 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 19:44 [PATCH] dt-bindings: usb: realtek,rts5411: Add missing "additionalProperties" on child nodes Rob Herring (Arm)
2024-05-23 21:21 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox