* [PATCH] dm cache metadata: remove unused struct 'thunk'
@ 2024-05-23 21:05 linux
2024-06-08 20:49 ` Dr. David Alan Gilbert
2024-06-25 18:37 ` Matthew Sakai
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-05-23 21:05 UTC (permalink / raw)
To: agk, snitzer, mpatocka; +Cc: dm-devel, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'thunk' has been unused since
commit f177940a8091 ("dm cache metadata: switch to using the new
cursor api for loading metadata").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/md/dm-cache-metadata.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 96751cd3d181..0ad9dc1824fa 100644
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
return r;
}
-struct thunk {
- load_mapping_fn fn;
- void *context;
-
- struct dm_cache_metadata *cmd;
- bool respect_dirty_flags;
- bool hints_valid;
-};
-
static bool policy_unchanged(struct dm_cache_metadata *cmd,
struct dm_cache_policy *policy)
{
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dm cache metadata: remove unused struct 'thunk'
2024-05-23 21:05 [PATCH] dm cache metadata: remove unused struct 'thunk' linux
@ 2024-06-08 20:49 ` Dr. David Alan Gilbert
2024-06-25 18:37 ` Matthew Sakai
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-06-08 20:49 UTC (permalink / raw)
To: agk, snitzer, mpatocka; +Cc: dm-devel, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping
> ---
> drivers/md/dm-cache-metadata.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
> return r;
> }
>
> -struct thunk {
> - load_mapping_fn fn;
> - void *context;
> -
> - struct dm_cache_metadata *cmd;
> - bool respect_dirty_flags;
> - bool hints_valid;
> -};
> -
> static bool policy_unchanged(struct dm_cache_metadata *cmd,
> struct dm_cache_policy *policy)
> {
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dm cache metadata: remove unused struct 'thunk'
2024-05-23 21:05 [PATCH] dm cache metadata: remove unused struct 'thunk' linux
2024-06-08 20:49 ` Dr. David Alan Gilbert
@ 2024-06-25 18:37 ` Matthew Sakai
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Sakai @ 2024-06-25 18:37 UTC (permalink / raw)
To: linux, agk, snitzer, mpatocka; +Cc: dm-devel, linux-kernel
On 5/23/24 17:05, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Matthew Sakai <msakai@redhat.com>
> ---
> drivers/md/dm-cache-metadata.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
> return r;
> }
>
> -struct thunk {
> - load_mapping_fn fn;
> - void *context;
> -
> - struct dm_cache_metadata *cmd;
> - bool respect_dirty_flags;
> - bool hints_valid;
> -};
> -
> static bool policy_unchanged(struct dm_cache_metadata *cmd,
> struct dm_cache_policy *policy)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-25 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 21:05 [PATCH] dm cache metadata: remove unused struct 'thunk' linux
2024-06-08 20:49 ` Dr. David Alan Gilbert
2024-06-25 18:37 ` Matthew Sakai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox