* [PATCH] dm vdo: remove unused struct 'uds_attribute'
@ 2024-05-23 21:07 linux
2024-05-24 0:57 ` Matthew Sakai
0 siblings, 1 reply; 4+ messages in thread
From: linux @ 2024-05-23 21:07 UTC (permalink / raw)
To: msakai; +Cc: dm-devel, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'uds_attribute' is unused since
commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/md/dm-vdo/dedupe.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
index 117266e1b3ae..39ac68614419 100644
--- a/drivers/md/dm-vdo/dedupe.c
+++ b/drivers/md/dm-vdo/dedupe.c
@@ -148,11 +148,6 @@
#include "vdo.h"
#include "wait-queue.h"
-struct uds_attribute {
- struct attribute attr;
- const char *(*show_string)(struct hash_zones *hash_zones);
-};
-
#define DEDUPE_QUERY_TIMER_IDLE 0
#define DEDUPE_QUERY_TIMER_RUNNING 1
#define DEDUPE_QUERY_TIMER_FIRED 2
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
2024-05-23 21:07 [PATCH] dm vdo: remove unused struct 'uds_attribute' linux
@ 2024-05-24 0:57 ` Matthew Sakai
2024-05-24 1:09 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Sakai @ 2024-05-24 0:57 UTC (permalink / raw)
To: linux; +Cc: dm-devel, linux-kernel
On 5/23/24 17:07, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'uds_attribute' is unused since
> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Yes, this was clearly an oversight on our part. Feel free to add:
Reviewed-by: Matthew Sakai <msakai@redhat.com>
> ---
> drivers/md/dm-vdo/dedupe.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> index 117266e1b3ae..39ac68614419 100644
> --- a/drivers/md/dm-vdo/dedupe.c
> +++ b/drivers/md/dm-vdo/dedupe.c
> @@ -148,11 +148,6 @@
> #include "vdo.h"
> #include "wait-queue.h"
>
> -struct uds_attribute {
> - struct attribute attr;
> - const char *(*show_string)(struct hash_zones *hash_zones);
> -};
> -
> #define DEDUPE_QUERY_TIMER_IDLE 0
> #define DEDUPE_QUERY_TIMER_RUNNING 1
> #define DEDUPE_QUERY_TIMER_FIRED 2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
2024-05-24 0:57 ` Matthew Sakai
@ 2024-05-24 1:09 ` Dr. David Alan Gilbert
2024-05-24 1:34 ` Matthew Sakai
0 siblings, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2024-05-24 1:09 UTC (permalink / raw)
To: Matthew Sakai; +Cc: dm-devel, linux-kernel
* Matthew Sakai (msakai@redhat.com) wrote:
> On 5/23/24 17:07, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'uds_attribute' is unused since
> > commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Yes, this was clearly an oversight on our part. Feel free to add:
> Reviewed-by: Matthew Sakai <msakai@redhat.com>
Thanks for the quick review.
Is this something you'll send a pull for, or do I need to
ask someone else to include it?
Dave
> > ---
> > drivers/md/dm-vdo/dedupe.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> > index 117266e1b3ae..39ac68614419 100644
> > --- a/drivers/md/dm-vdo/dedupe.c
> > +++ b/drivers/md/dm-vdo/dedupe.c
> > @@ -148,11 +148,6 @@
> > #include "vdo.h"
> > #include "wait-queue.h"
> > -struct uds_attribute {
> > - struct attribute attr;
> > - const char *(*show_string)(struct hash_zones *hash_zones);
> > -};
> > -
> > #define DEDUPE_QUERY_TIMER_IDLE 0
> > #define DEDUPE_QUERY_TIMER_RUNNING 1
> > #define DEDUPE_QUERY_TIMER_FIRED 2
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dm vdo: remove unused struct 'uds_attribute'
2024-05-24 1:09 ` Dr. David Alan Gilbert
@ 2024-05-24 1:34 ` Matthew Sakai
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Sakai @ 2024-05-24 1:34 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: dm-devel, linux-kernel, Mike Snitzer, Mikulas Patocka
On 5/23/24 21:09, Dr. David Alan Gilbert wrote:
> * Matthew Sakai (msakai@redhat.com) wrote:
>> On 5/23/24 17:07, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'uds_attribute' is unused since
>>> commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
>>>
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>
>> Yes, this was clearly an oversight on our part. Feel free to add:
>> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>
> Thanks for the quick review.
> Is this something you'll send a pull for, or do I need to
> ask someone else to include it?
No need to do anything else, I think. Mike (or Mikulas), can you
include this with the next set of device mapper patches?
> Dave
>
>>> ---
>>> drivers/md/dm-vdo/dedupe.c | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
>>> index 117266e1b3ae..39ac68614419 100644
>>> --- a/drivers/md/dm-vdo/dedupe.c
>>> +++ b/drivers/md/dm-vdo/dedupe.c
>>> @@ -148,11 +148,6 @@
>>> #include "vdo.h"
>>> #include "wait-queue.h"
>>> -struct uds_attribute {
>>> - struct attribute attr;
>>> - const char *(*show_string)(struct hash_zones *hash_zones);
>>> -};
>>> -
>>> #define DEDUPE_QUERY_TIMER_IDLE 0
>>> #define DEDUPE_QUERY_TIMER_RUNNING 1
>>> #define DEDUPE_QUERY_TIMER_FIRED 2
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-24 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 21:07 [PATCH] dm vdo: remove unused struct 'uds_attribute' linux
2024-05-24 0:57 ` Matthew Sakai
2024-05-24 1:09 ` Dr. David Alan Gilbert
2024-05-24 1:34 ` Matthew Sakai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox