public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2] Check whether divisor is non-zero before division
@ 2024-05-23  9:26 Shichao Lai
  2024-05-23  9:32 ` Greg KH
  2024-05-23 13:58 ` Alan Stern
  0 siblings, 2 replies; 10+ messages in thread
From: Shichao Lai @ 2024-05-23  9:26 UTC (permalink / raw)
  To: stern, gregkh, oneukum
  Cc: linux-usb, usb-storage, linux-kernel, Shichao Lai, xingwei lee,
	yue sun

Since uzonesize may be zero, so judgements for non-zero are nessesary in both place.
Previous check is moved out of loop, and one more check is added in alauda_write_lba.

Reported-by: xingwei lee <xrivendell7@gmail.com>
Reported-by: yue sun <samsun1006219@gmail.com>
Signed-off-by: Shichao Lai <shichaorai@gmail.com>
---
 drivers/usb/storage/alauda.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 115f05a6201a..a6e60ef5cb0d 100644
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -818,6 +818,8 @@ static int alauda_write_lba(struct us_data *us, u16 lba,
 	unsigned int blocksize = MEDIA_INFO(us).blocksize;
 	unsigned int lba_offset = lba % uzonesize;
 	unsigned int new_pba_offset;
+	if (!uzonesize)
+		return USB_STOR_TRANSPORT_ERROR;
 	unsigned int zone = lba / uzonesize;
 
 	alauda_ensure_map_for_zone(us, zone);
@@ -923,6 +925,8 @@ static int alauda_read_data(struct us_data *us, unsigned long address,
 	unsigned int uzonesize = MEDIA_INFO(us).uzonesize;
 	struct scatterlist *sg;
 	int result;
+	if (!uzonesize)
+		return USB_STOR_TRANSPORT_ERROR;
 
 	/*
 	 * Since we only read in one block at a time, we have to create
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-05-25  4:35 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23  9:26 [PATCHv2] Check whether divisor is non-zero before division Shichao Lai
2024-05-23  9:32 ` Greg KH
2024-05-23 13:58 ` Alan Stern
2024-05-23 14:15   ` Alan Stern
2024-05-23 15:13     ` shichao lai
2024-05-23 15:21       ` shichao lai
2024-05-23 16:30       ` Alan Stern
2024-05-24  2:13         ` shichao lai
2024-05-25  2:24           ` Alan Stern
2024-05-25  4:35             ` shichao lai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox