Re: [PATCH v4 1/2] proc: pass file instead of inode to proc_mem_open

Kees Cook
2024-05-31T21:14:04Z

On Fri, May 24, 2024 at 10:28:57PM +0300, Adrian Ratiu wrote:
> The file struct is required in proc_mem_open() so its
> f_mode can be checked when deciding whether to allow or
> deny /proc/*/mem open requests via the new read/write
> and foll_force restriction mechanism.
>
> Thus instead of directly passing the inode to the fun,
> we pass the file and get the inode inside it.
>
> Cc: Jann Horn <jannh@google.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>

With the nommu errors pointed out by 0day fixed:

Reviewed-by: Kees Cook <kees@kernel.org>

--
Kees Cook