Re: [PATCH v4 1/2] proc: pass file instead of inode to proc_mem_open

kernel test robot
2024-05-24T21:57:27Z

Hi Adrian,

kernel test robot noticed the following build errors:

[auto build test ERROR on kees/for-next/pstore]
[also build test ERROR on kees/for-next/kspp linus/master v6.9 next-20240523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Adrian-Ratiu/proc-restrict-proc-pid-mem/20240525-033201
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link: https://lore.kernel.org/r/20240524192858.3206-1-adrian.ratiu%40collabora.com
patch subject: [PATCH v4 1/2] proc: pass file instead of inode to proc_mem_open
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20240525/202405250507.0z0WHg9L-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/202405250507.0z0WHg9L-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405250507.0z0WHg9L-lkp@intel.com/

All errors (new ones prefixed by >>):

fs/proc/task_nommu.c: In function 'maps_open':
>> fs/proc/task_nommu.c:262:34: error: passing argument 1 of 'proc_mem_open' from incompatible pointer type [-Werror=incompatible-pointer-types]
262 | priv->mm = proc_mem_open(inode, PTRACE_MODE_READ);
| ^~~~~
| |
| struct inode *
In file included from fs/proc/task_nommu.c:13:
fs/proc/internal.h:298:46: note: expected 'struct file *' but argument is of type 'struct inode *'
298 | struct mm_struct *proc_mem_open(struct file *file, unsigned int mode);
| ~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors

vim +/proc_mem_open +262 fs/proc/task_nommu.c

b76437579d1344 Siddhesh Poyarekar 2012-03-21 251
b76437579d1344 Siddhesh Poyarekar 2012-03-21 252 static int maps_open(struct inode *inode, struct file *file,
b76437579d1344 Siddhesh Poyarekar 2012-03-21 253 const struct seq_operations *ops)
662795deb854b3 Eric W. Biederman 2006-06-26 254 {
dbf8685c8e2140 David Howells 2006-09-27 255 struct proc_maps_private *priv;
dbf8685c8e2140 David Howells 2006-09-27 256
27692cd56e2aa6 Oleg Nesterov 2014-10-09 257 priv = __seq_open_private(file, ops, sizeof(*priv));
ce34fddb5bafb4 Oleg Nesterov 2014-10-09 258 if (!priv)
ce34fddb5bafb4 Oleg Nesterov 2014-10-09 259 return -ENOMEM;
ce34fddb5bafb4 Oleg Nesterov 2014-10-09 260
2c03376d2db005 Oleg Nesterov 2014-10-09 261 priv->inode = inode;
27692cd56e2aa6 Oleg Nesterov 2014-10-09 @262 priv->mm = proc_mem_open(inode, PTRACE_MODE_READ);
27692cd56e2aa6 Oleg Nesterov 2014-10-09 263 if (IS_ERR(priv->mm)) {
27692cd56e2aa6 Oleg Nesterov 2014-10-09 264 int err = PTR_ERR(priv->mm);
27692cd56e2aa6 Oleg Nesterov 2014-10-09 265
27692cd56e2aa6 Oleg Nesterov 2014-10-09 266 seq_release_private(inode, file);
27692cd56e2aa6 Oleg Nesterov 2014-10-09 267 return err;
27692cd56e2aa6 Oleg Nesterov 2014-10-09 268 }
27692cd56e2aa6 Oleg Nesterov 2014-10-09 269
ce34fddb5bafb4 Oleg Nesterov 2014-10-09 270 return 0;
662795deb854b3 Eric W. Biederman 2006-06-26 271 }
662795deb854b3 Eric W. Biederman 2006-06-26 272

--
0-DAY CI Kernel Test Service