From: kernel test robot <lkp@intel.com>
To: Thorsten Blum <thorsten.blum@toblux.com>,
Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Thorsten Blum <thorsten.blum@toblux.com>
Subject: Re: [PATCH] x86/asm/bitops: Change function return types from long to int
Date: Sun, 26 May 2024 07:00:58 +0800 [thread overview]
Message-ID: <202405260651.QCsLIzXc-lkp@intel.com> (raw)
In-Reply-To: <20240525174448.174824-2-thorsten.blum@toblux.com>
Hi Thorsten,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0b32d436c015d5a88b3368405e3d8fe82f195a54]
url: https://github.com/intel-lab-lkp/linux/commits/Thorsten-Blum/x86-asm-bitops-Change-function-return-types-from-long-to-int/20240526-014828
base: 0b32d436c015d5a88b3368405e3d8fe82f195a54
patch link: https://lore.kernel.org/r/20240525174448.174824-2-thorsten.blum%40toblux.com
patch subject: [PATCH] x86/asm/bitops: Change function return types from long to int
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240526/202405260651.QCsLIzXc-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240526/202405260651.QCsLIzXc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405260651.QCsLIzXc-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:573,
from include/asm-generic/bug.h:22,
from arch/x86/include/asm/bug.h:87,
from include/linux/bug.h:5,
from include/linux/fortify-string.h:6,
from include/linux/string.h:374,
from arch/x86/include/asm/page_32.h:18,
from arch/x86/include/asm/page.h:14,
from arch/x86/include/asm/processor.h:20,
from include/linux/sched.h:13,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/devcoredump.h:8,
from sound/soc/intel/catpt/dsp.c:8:
sound/soc/intel/catpt/dsp.c: In function 'catpt_dsp_set_srampge':
>> sound/soc/intel/catpt/dsp.c:181:44: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'u32' {aka 'unsigned int'} [-Wformat=]
181 | dev_dbg(cdev->dev, "sanitize block %ld: off 0x%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:165:9: note: in expansion of macro 'dynamic_dev_dbg'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:165:30: note: in expansion of macro 'dev_fmt'
165 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/soc/intel/catpt/dsp.c:181:25: note: in expansion of macro 'dev_dbg'
181 | dev_dbg(cdev->dev, "sanitize block %ld: off 0x%08x\n",
| ^~~~~~~
sound/soc/intel/catpt/dsp.c:181:62: note: format string is defined here
181 | dev_dbg(cdev->dev, "sanitize block %ld: off 0x%08x\n",
| ~~^
| |
| long int
| %d
vim +181 sound/soc/intel/catpt/dsp.c
64b9b1b005743a Cezary Rojewski 2020-09-29 153
ba202a7bc3da05 Cezary Rojewski 2020-09-29 154 static void catpt_dsp_set_srampge(struct catpt_dev *cdev, struct resource *sram,
ba202a7bc3da05 Cezary Rojewski 2020-09-29 155 unsigned long mask, unsigned long new)
ba202a7bc3da05 Cezary Rojewski 2020-09-29 156 {
ba202a7bc3da05 Cezary Rojewski 2020-09-29 157 unsigned long old;
ba202a7bc3da05 Cezary Rojewski 2020-09-29 158 u32 off = sram->start;
ba202a7bc3da05 Cezary Rojewski 2020-09-29 159 u32 b = __ffs(mask);
ba202a7bc3da05 Cezary Rojewski 2020-09-29 160
ba202a7bc3da05 Cezary Rojewski 2020-09-29 161 old = catpt_readl_pci(cdev, VDRTCTL0) & mask;
ba202a7bc3da05 Cezary Rojewski 2020-09-29 162 dev_dbg(cdev->dev, "SRAMPGE [0x%08lx] 0x%08lx -> 0x%08lx",
ba202a7bc3da05 Cezary Rojewski 2020-09-29 163 mask, old, new);
ba202a7bc3da05 Cezary Rojewski 2020-09-29 164
ba202a7bc3da05 Cezary Rojewski 2020-09-29 165 if (old == new)
ba202a7bc3da05 Cezary Rojewski 2020-09-29 166 return;
ba202a7bc3da05 Cezary Rojewski 2020-09-29 167
ba202a7bc3da05 Cezary Rojewski 2020-09-29 168 catpt_updatel_pci(cdev, VDRTCTL0, mask, new);
ba202a7bc3da05 Cezary Rojewski 2020-09-29 169 /* wait for SRAM power gating to propagate */
ba202a7bc3da05 Cezary Rojewski 2020-09-29 170 udelay(60);
ba202a7bc3da05 Cezary Rojewski 2020-09-29 171
ba202a7bc3da05 Cezary Rojewski 2020-09-29 172 /*
ba202a7bc3da05 Cezary Rojewski 2020-09-29 173 * Dummy read as the very first access after block enable
ba202a7bc3da05 Cezary Rojewski 2020-09-29 174 * to prevent byte loss in future operations.
ba202a7bc3da05 Cezary Rojewski 2020-09-29 175 */
ba202a7bc3da05 Cezary Rojewski 2020-09-29 176 for_each_clear_bit_from(b, &new, fls_long(mask)) {
ba202a7bc3da05 Cezary Rojewski 2020-09-29 177 u8 buf[4];
ba202a7bc3da05 Cezary Rojewski 2020-09-29 178
ba202a7bc3da05 Cezary Rojewski 2020-09-29 179 /* newly enabled: new bit=0 while old bit=1 */
ba202a7bc3da05 Cezary Rojewski 2020-09-29 180 if (test_bit(b, &old)) {
ba202a7bc3da05 Cezary Rojewski 2020-09-29 @181 dev_dbg(cdev->dev, "sanitize block %ld: off 0x%08x\n",
ba202a7bc3da05 Cezary Rojewski 2020-09-29 182 b - __ffs(mask), off);
ba202a7bc3da05 Cezary Rojewski 2020-09-29 183 memcpy_fromio(buf, cdev->lpe_ba + off, sizeof(buf));
ba202a7bc3da05 Cezary Rojewski 2020-09-29 184 }
ba202a7bc3da05 Cezary Rojewski 2020-09-29 185 off += CATPT_MEMBLOCK_SIZE;
ba202a7bc3da05 Cezary Rojewski 2020-09-29 186 }
ba202a7bc3da05 Cezary Rojewski 2020-09-29 187 }
ba202a7bc3da05 Cezary Rojewski 2020-09-29 188
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-05-25 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 17:44 [PATCH] x86/asm/bitops: Change function return types from long to int Thorsten Blum
2024-05-25 23:00 ` kernel test robot [this message]
2024-05-26 3:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405260651.QCsLIzXc-lkp@intel.com \
--to=lkp@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@toblux.com \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox