From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DE44D59B; Tue, 28 May 2024 02:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716862754; cv=none; b=Bl1M5vVWXdgsGyBCtFVXyyS8v7VTQe1qEOPR5l2fcO09sjFGNx+unRXtJoIiwTjmvpye1D7Svq4qVTbnabBx9ASbS8eOFU3Aw7Oo0gQAXAjGrH9Hq1l0Dy3tJFra9hj63huJp3W9dObdI+NpSfPpiiw7vzRs3M4Aeseyuv0jwwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716862754; c=relaxed/simple; bh=Ai6O9eTJDkIJpA+tWGRVeg1IerME6NvfCXXrdyN+IMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y22fWyCo3tCD8u8NtsykH95gBkl7HxAqz/jnoR/lHXjVlWrRl/iHQzwu9mjnbd7in7rPNr5SzNFOM5XqmUhwnkCRO8BR9wIxYf4cJ7CMlaTEQa8wOD+yBuvjL8x7lv71DdFOVp3D2EGKoRhC9eWh5LfGvANTb83TirMOLmCAoMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q+w/Z6Jp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q+w/Z6Jp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF7A5C32782; Tue, 28 May 2024 02:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716862754; bh=Ai6O9eTJDkIJpA+tWGRVeg1IerME6NvfCXXrdyN+IMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+w/Z6JpuE209eFa5NNftiPXvA5uFt6zEQp9rqQBNKx0wAMinR+Faz9f6nRD62gW/ DnkqihegSACJ5KSp1nmvPuXeEdE+4wLPzQZDXMMHf/bl5X2tM+ib7COSxHKHtCuW9Q 2WaTiU6T+BjN1EpEflTBey8/8p0ixqmnVHFoDlP7H2KVS456fsJsANKM/M7xsYx7Wy kMSzKtKQ9a5uAihAr6/WJtTMjoz8WkqRmI0BNotTJgJFG3jifJTk+FFU/D/SArJp8S SI7nQnI4YBAyO56KxVdQ+r2MaSvUk9DJymRrdQ2g/GkA73R4bv7xd9qtH+z7gTrvM3 Al+QS+nSEmeDA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aleksandr Aprelkov , Will Deacon , Sasha Levin , joro@8bytes.org, iommu@lists.linux-foundation.org Subject: [PATCH AUTOSEL 6.1 2/2] iommu/arm-smmu-v3: Free MSIs in case of ENOMEM Date: Mon, 27 May 2024 22:19:08 -0400 Message-ID: <20240528021909.3905362-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240528021909.3905362-1-sashal@kernel.org> References: <20240528021909.3905362-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.92 Content-Transfer-Encoding: 8bit From: Aleksandr Aprelkov [ Upstream commit 80fea979dd9d48d67c5b48d2f690c5da3e543ebd ] If devm_add_action() returns -ENOMEM, then MSIs are allocated but not not freed on teardown. Use devm_add_action_or_reset() instead to keep the static analyser happy. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Aleksandr Aprelkov Link: https://lore.kernel.org/r/20240403053759.643164-1-aaprelkov@usergate.com [will: Tweak commit message, remove warning message] Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index 82f100e591b5a..45b43f729f895 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -3199,7 +3199,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu) smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX); /* Add callback to free MSIs on teardown */ - devm_add_action(dev, arm_smmu_free_msis, dev); + devm_add_action_or_reset(dev, arm_smmu_free_msis, dev); } static void arm_smmu_setup_unique_irqs(struct arm_smmu_device *smmu) -- 2.43.0