Re: [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints

Alina Yu
2024-05-29T06:51:30Z

On Mon, May 27, 2024 at 02:00:47PM +0100, Mark Brown wrote:
> On Thu, May 16, 2024 at 05:20:33PM +0800, Alina Yu wrote:
> > A fixed LDO VOUT property has been added to specify the fixed_uV of the regulator_desc.
> > Additionally, a check has been included in this version
> > to ensure that the fixed_uV matches the constraints.
>
> This doesn't apply against current code, please check and resend.

Regarding the previous discussion in

https://lore.kernel.org/all/20240528060731.GA25526@linuxcarl2.richtek.com/

I found some patches missing in the linux-next tree.

So I merged the missing part in my latest resent sereies.

The issue has been addressed in

In '[RESEND 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout'
https://lore.kernel.org/all/5ad4c7728c7fa7f6286db36b99d31c9d0f5d16c7.1716870419.git.alina_yu@richtek.com/

@@ -219,7 +219,7 @@ static const struct regulator_ops rtq2208_regulator_buck_ops = {
.set_suspend_mode = rtq2208_set_suspend_mode,
};

-static const struct regulator_ops rtq2208_regulator_ldo_ops = {
+static const struct regulator_ops rtq2208_regulator_ldo_fix_ops = {
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
.is_enabled = regulator_is_enabled_regmap,

...

Thanks,
Alina