RE: [PATCH v19 00/20] Add support for Sub-NUMA cluster (SNC) systems

Luck, Tony
2024-05-30T22:49:39Z

> btw ... the static checker I ran did have four other complaints, three about
> uninitialized data and one about divide by zero. Most problems appear to be
> in mbm_update() that does not initialize rr.sumdomains nor rr.ci before
> calling __mon_event_count().
>
> Please use available tools to check code before posting.

Which static checker? I tried smatch and it only finds one:

arch/x86/kernel/cpu/resctrl/rdtgroup.c:3129 mkdir_mondata_subdir() error: uninitialized symbol 'ret'.

Which is a false positive (but I don't fault smatch for not understanding the relationship
between the two "if" blocks in this function.

-Tony