public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
Cc: Yi Liu <yi.l.liu@intel.com>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Kalle Valo <kvalo@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	mst@redhat.com, Jason Wang <jasowang@redhat.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	iommu@lists.linux.dev, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 00/20] iommu: Refactoring domain allocation interface
Date: Wed, 29 May 2024 13:32:30 +0800	[thread overview]
Message-ID: <20240529053250.91284-1-baolu.lu@linux.intel.com> (raw)

The IOMMU subsystem has undergone some changes, including the removal
of iommu_ops from the bus structure. Consequently, the existing domain
allocation interface, which relies on a bus type argument, is no longer
relevant:

    struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)

This series is designed to refactor the use of this interface. It
proposes two new interfaces to replace iommu_domain_alloc():

- iommu_user_domain_alloc(): This interface is intended for allocating
  iommu domains managed by userspace for device passthrough scenarios,
  such as those used by iommufd, vfio, and vdpa. It clearly indicates
  that the domain is for user-managed device DMA.

  If an IOMMU driver does not implement iommu_ops->domain_alloc_user,
  this interface will rollback to the generic paging domain allocation.

- iommu_paging_domain_alloc(): This interface is for allocating iommu
  domains managed by kernel drivers for kernel DMA purposes. It takes a
  device pointer as a parameter, which better reflects the current
  design of the IOMMU subsystem.

The majority of device drivers currently using iommu_domain_alloc() do
so to allocate a domain for a specific device and then attach that
domain to the device. These cases can be straightforwardly migrated to
the new interfaces.

However, there are some drivers with more complex use cases that do
not fit neatly into this new scheme. For example:

$ git grep "= iommu_domain_alloc"
arch/arm/mm/dma-mapping.c:      mapping->domain = iommu_domain_alloc(bus);
drivers/gpu/drm/rockchip/rockchip_drm_drv.c:    private->domain = iommu_domain_alloc(private->iommu_dev->bus);
drivers/gpu/drm/tegra/drm.c:            tegra->domain = iommu_domain_alloc(&platform_bus_type);
drivers/infiniband/hw/usnic/usnic_uiom.c:       pd->domain = domain = iommu_domain_alloc(dev->bus);

This series leave those cases unchanged and keep iommu_domain_alloc()
for their usage. But new drivers should not use it anymore.

The whole series is also available on GitHub:
https://github.com/LuBaolu/intel-iommu/commits/iommu-domain-allocation-refactor-v1

Lu Baolu (20):
  iommu: Add iommu_user_domain_alloc() interface
  iommufd: Use iommu_user_domain_alloc()
  vfio/type1: Use iommu_paging_domain_alloc()
  vhost-vdpa: Use iommu_user_domain_alloc()
  iommu: Add iommu_paging_domain_alloc() interface
  drm/msm: Use iommu_paging_domain_alloc()
  drm/nouveau/tegra: Use iommu_paging_domain_alloc()
  gpu: host1x: Use iommu_paging_domain_alloc()
  media: nvidia: tegra: Use iommu_paging_domain_alloc()
  media: venus: firmware: Use iommu_paging_domain_alloc()
  ath10k: Use iommu_paging_domain_alloc()
  wifi: ath11k: Use iommu_paging_domain_alloc()
  remoteproc: Use iommu_paging_domain_alloc()
  soc/fsl/qbman: Use iommu_paging_domain_alloc()
  iommu/vt-d: Add helper to allocate paging domain
  iommu/vt-d: Add domain_alloc_paging support
  iommu/vt-d: Simplify compatibility check for identity domain
  iommu/vt-d: Enhance compatibility check for paging domain attach
  iommu/vt-d: Remove domain_update_iommu_cap()
  iommu/vt-d: Remove domain_update_iommu_superpage()

 include/linux/iommu.h                         |  12 +
 drivers/gpu/drm/msm/msm_iommu.c               |   8 +-
 .../drm/nouveau/nvkm/engine/device/tegra.c    |   4 +-
 drivers/gpu/host1x/dev.c                      |   6 +-
 drivers/iommu/intel/iommu.c                   | 319 ++++++++----------
 drivers/iommu/intel/pasid.c                   |  28 +-
 drivers/iommu/iommu.c                         |  62 ++++
 drivers/iommu/iommufd/hw_pagetable.c          |  20 +-
 .../media/platform/nvidia/tegra-vde/iommu.c   |   6 +-
 drivers/media/platform/qcom/venus/firmware.c  |   6 +-
 drivers/net/wireless/ath/ath10k/snoc.c        |   6 +-
 drivers/net/wireless/ath/ath11k/ahb.c         |   6 +-
 drivers/remoteproc/remoteproc_core.c          |   6 +-
 drivers/soc/fsl/qbman/qman_portal.c           |   4 +-
 drivers/vfio/vfio_iommu_type1.c               |   7 +-
 drivers/vhost/vdpa.c                          |  11 +-
 16 files changed, 253 insertions(+), 258 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-05-29  5:36 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29  5:32 Lu Baolu [this message]
2024-05-29  5:32 ` [PATCH 01/20] iommu: Add iommu_user_domain_alloc() interface Lu Baolu
2024-05-29  5:32 ` [PATCH 02/20] iommufd: Use iommu_user_domain_alloc() Lu Baolu
2024-05-29  5:32 ` [PATCH 03/20] vfio/type1: Use iommu_paging_domain_alloc() Lu Baolu
2024-05-29  5:32 ` [PATCH 04/20] vhost-vdpa: Use iommu_user_domain_alloc() Lu Baolu
2024-05-29  5:32 ` [PATCH 05/20] iommu: Add iommu_paging_domain_alloc() interface Lu Baolu
2024-05-29  9:04   ` Yi Liu
2024-05-30  1:59     ` Baolu Lu
2024-05-30  3:09       ` Baolu Lu
2024-05-29  5:32 ` [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc() Lu Baolu
2024-05-29  8:21   ` Dmitry Baryshkov
2024-05-30  1:57     ` Baolu Lu
2024-05-30  7:58       ` Dmitry Baryshkov
2024-05-31  1:57         ` Baolu Lu
2024-05-31  8:30           ` Dmitry Baryshkov
2024-05-29  5:32 ` [PATCH 07/20] drm/nouveau/tegra: " Lu Baolu
2024-05-29  5:32 ` [PATCH 08/20] gpu: host1x: " Lu Baolu
2024-05-29  5:32 ` [PATCH 09/20] media: nvidia: tegra: " Lu Baolu
2024-05-29  5:32 ` [PATCH 10/20] media: venus: firmware: " Lu Baolu
2024-05-29  5:32 ` [PATCH 11/20] ath10k: " Lu Baolu
2024-05-29  5:32 ` [PATCH 12/20] wifi: ath11k: " Lu Baolu
2024-05-29  5:32 ` [PATCH 13/20] remoteproc: " Lu Baolu
2024-05-29  5:32 ` [PATCH 14/20] soc/fsl/qbman: " Lu Baolu
2024-05-29  5:32 ` [PATCH 15/20] iommu/vt-d: Add helper to allocate paging domain Lu Baolu
2024-05-29  5:32 ` [PATCH 16/20] iommu/vt-d: Add domain_alloc_paging support Lu Baolu
2024-05-29  5:32 ` [PATCH 17/20] iommu/vt-d: Simplify compatibility check for identity domain Lu Baolu
2024-05-29  5:32 ` [PATCH 18/20] iommu/vt-d: Enhance compatibility check for paging domain attach Lu Baolu
2024-05-29  5:32 ` [PATCH 19/20] iommu/vt-d: Remove domain_update_iommu_cap() Lu Baolu
2024-05-29  5:32 ` [PATCH 20/20] iommu/vt-d: Remove domain_update_iommu_superpage() Lu Baolu
2024-05-29  9:03 ` [PATCH 00/20] iommu: Refactoring domain allocation interface Yi Liu
2024-05-29 12:02   ` Baolu Lu
2024-05-31  3:16     ` Yi Liu
2024-05-31  6:00       ` Baolu Lu
2024-05-31  6:24         ` Yi Liu
2024-06-03 13:35     ` Jason Gunthorpe
2024-06-04  1:02       ` Baolu Lu
2024-05-30 17:59 ` Robin Murphy
2024-05-31  2:52   ` Baolu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240529053250.91284-1-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mperttunen@nvidia.com \
    --cc=mst@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox