From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
Cc: Yi Liu <yi.l.liu@intel.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Kalle Valo <kvalo@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
mst@redhat.com, Jason Wang <jasowang@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
iommu@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH 05/20] iommu: Add iommu_paging_domain_alloc() interface
Date: Wed, 29 May 2024 13:32:35 +0800 [thread overview]
Message-ID: <20240529053250.91284-6-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240529053250.91284-1-baolu.lu@linux.intel.com>
Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from
bus. The iommu subsystem no longer relies on bus for operations. So the
bus parameter in iommu_domain_alloc() is no longer relevant.
Add a new interface named iommu_paging_domain_alloc(), which explicitly
indicates the allocation of a paging domain for DMA managed by a kernel
driver. The new interface takes a device pointer as its parameter, that
better aligns with the current iommu subsystem.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/iommu.h | 6 ++++++
drivers/iommu/iommu.c | 20 ++++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 6648b2415474..16401de7802d 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -781,6 +781,7 @@ extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
extern struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus);
struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags);
+struct iommu_domain *iommu_paging_domain_alloc(struct device *dev);
extern void iommu_domain_free(struct iommu_domain *domain);
extern int iommu_attach_device(struct iommu_domain *domain,
struct device *dev);
@@ -1092,6 +1093,11 @@ static inline struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u
return ERR_PTR(-ENODEV);
}
+static inline struct iommu_domain *iommu_paging_domain_alloc(struct device *dev)
+{
+ return ERR_PTR(-ENODEV);
+}
+
static inline void iommu_domain_free(struct iommu_domain *domain)
{
}
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index f1416892ef8e..7df4a021b040 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -2016,6 +2016,10 @@ static int __iommu_domain_alloc_dev(struct device *dev, void *data)
return 0;
}
+/*
+ * The iommu ops in bus has been retired. Do not use this interface in
+ * new drivers.
+ */
struct iommu_domain *iommu_domain_alloc(const struct bus_type *bus)
{
const struct iommu_ops *ops = NULL;
@@ -2074,6 +2078,22 @@ struct iommu_domain *iommu_user_domain_alloc(struct device *dev, u32 flags)
}
EXPORT_SYMBOL_GPL(iommu_user_domain_alloc);
+/**
+ * iommu_paging_domain_alloc() - Allocate a paging domain
+ * @dev: device for which the domain is allocated
+ *
+ * Allocate a paging domain which will be managed by a kernel driver. Return
+ * allocated domain if successful, or a ERR pointer for failure.
+ */
+struct iommu_domain *iommu_paging_domain_alloc(struct device *dev)
+{
+ if (!dev_has_iommu(dev))
+ return ERR_PTR(-ENODEV);
+
+ return __iommu_domain_alloc(dev_iommu_ops(dev), dev, IOMMU_DOMAIN_UNMANAGED);
+}
+EXPORT_SYMBOL_GPL(iommu_paging_domain_alloc);
+
void iommu_domain_free(struct iommu_domain *domain)
{
if (domain->type == IOMMU_DOMAIN_SVA)
--
2.34.1
next prev parent reply other threads:[~2024-05-29 5:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 5:32 [PATCH 00/20] iommu: Refactoring domain allocation interface Lu Baolu
2024-05-29 5:32 ` [PATCH 01/20] iommu: Add iommu_user_domain_alloc() interface Lu Baolu
2024-05-29 5:32 ` [PATCH 02/20] iommufd: Use iommu_user_domain_alloc() Lu Baolu
2024-05-29 5:32 ` [PATCH 03/20] vfio/type1: Use iommu_paging_domain_alloc() Lu Baolu
2024-05-29 5:32 ` [PATCH 04/20] vhost-vdpa: Use iommu_user_domain_alloc() Lu Baolu
2024-05-29 5:32 ` Lu Baolu [this message]
2024-05-29 9:04 ` [PATCH 05/20] iommu: Add iommu_paging_domain_alloc() interface Yi Liu
2024-05-30 1:59 ` Baolu Lu
2024-05-30 3:09 ` Baolu Lu
2024-05-29 5:32 ` [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc() Lu Baolu
2024-05-29 8:21 ` Dmitry Baryshkov
2024-05-30 1:57 ` Baolu Lu
2024-05-30 7:58 ` Dmitry Baryshkov
2024-05-31 1:57 ` Baolu Lu
2024-05-31 8:30 ` Dmitry Baryshkov
2024-05-29 5:32 ` [PATCH 07/20] drm/nouveau/tegra: " Lu Baolu
2024-05-29 5:32 ` [PATCH 08/20] gpu: host1x: " Lu Baolu
2024-05-29 5:32 ` [PATCH 09/20] media: nvidia: tegra: " Lu Baolu
2024-05-29 5:32 ` [PATCH 10/20] media: venus: firmware: " Lu Baolu
2024-05-29 5:32 ` [PATCH 11/20] ath10k: " Lu Baolu
2024-05-29 5:32 ` [PATCH 12/20] wifi: ath11k: " Lu Baolu
2024-05-29 5:32 ` [PATCH 13/20] remoteproc: " Lu Baolu
2024-05-29 5:32 ` [PATCH 14/20] soc/fsl/qbman: " Lu Baolu
2024-05-29 5:32 ` [PATCH 15/20] iommu/vt-d: Add helper to allocate paging domain Lu Baolu
2024-05-29 5:32 ` [PATCH 16/20] iommu/vt-d: Add domain_alloc_paging support Lu Baolu
2024-05-29 5:32 ` [PATCH 17/20] iommu/vt-d: Simplify compatibility check for identity domain Lu Baolu
2024-05-29 5:32 ` [PATCH 18/20] iommu/vt-d: Enhance compatibility check for paging domain attach Lu Baolu
2024-05-29 5:32 ` [PATCH 19/20] iommu/vt-d: Remove domain_update_iommu_cap() Lu Baolu
2024-05-29 5:32 ` [PATCH 20/20] iommu/vt-d: Remove domain_update_iommu_superpage() Lu Baolu
2024-05-29 9:03 ` [PATCH 00/20] iommu: Refactoring domain allocation interface Yi Liu
2024-05-29 12:02 ` Baolu Lu
2024-05-31 3:16 ` Yi Liu
2024-05-31 6:00 ` Baolu Lu
2024-05-31 6:24 ` Yi Liu
2024-06-03 13:35 ` Jason Gunthorpe
2024-06-04 1:02 ` Baolu Lu
2024-05-30 17:59 ` Robin Murphy
2024-05-31 2:52 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529053250.91284-6-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=airlied@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mperttunen@nvidia.com \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox