From: Gary Guo <gary@garyguo.net>
To: "Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [RFC PATCH 2/2] kbuild: rust: provide an option to inline C helpers into Rust
Date: Wed, 29 May 2024 21:45:32 +0100 [thread overview]
Message-ID: <20240529214532.7804a7d2.gary@garyguo.net> (raw)
In-Reply-To: <20240529202817.3641974-3-gary@garyguo.net>
On Wed, 29 May 2024 21:28:15 +0100
Gary Guo <gary@garyguo.net> wrote:
> Makefile | 4 +++-
> lib/Kconfig.debug | 10 ++++++++++
> rust/Makefile | 34 ++++++++++++++++++++++++++++++----
> rust/exports.c | 3 +++
> rust/helpers.c | 41 +++++++++++++++++++++--------------------
> scripts/Makefile.build | 5 ++++-
> 6 files changed, 71 insertions(+), 26 deletions(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 895f4b696962..3abf96f14148 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -32,18 +32,19 @@
> #include <linux/spinlock.h>
> #include <linux/wait.h>
> #include <linux/workqueue.h>
> +#include "helpers.h"
I made a mistake during rebase and forgot to include rust/helpers.h in
this patch. The content is
```
#ifndef RUST_HELPERS_H
#define RUST_HELPERS_H
#include <linux/compiler_types.h>
#ifdef __BINDGEN__
#define __rust_helper
#else
#define __rust_helper inline
#endif
#endif
```
I'll include this in patch v2 but would like to get a general feedback
before sending another version.
next prev parent reply other threads:[~2024-05-29 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240529202817.3641974-1-gary@garyguo.net>
2024-05-29 20:28 ` [RFC PATCH 1/2] kbuild: rust: auto generate rust helper exports Gary Guo
2024-05-29 20:28 ` [RFC PATCH 2/2] kbuild: rust: provide an option to inline C helpers into Rust Gary Guo
2024-05-29 20:45 ` Gary Guo [this message]
2024-06-07 14:40 ` Matthew Maurer
2024-06-12 16:26 ` Gary Guo
2024-06-12 21:28 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529214532.7804a7d2.gary@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox