From: Greg KH <gregkh@linuxfoundation.org>
To: Soumya Khasnis <soumya.khasnis@sony.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
daniel.lezcano@linaro.org, festevam@denx.de, lee@kernel.org,
benjamin.bara@skidata.com, dmitry.osipenko@collabora.com,
ldmldm05@gmail.com, srinavasa.nagaraju@sony.com,
Madhusudan.Bobbili@sony.com, shingo.takeuchi@sony.com,
keita.aihara@sony.com, masaya.takahashi@sony.com
Subject: Re: [PATCH] reboot: Add timeout for device shutdown
Date: Wed, 29 May 2024 12:00:54 +0200 [thread overview]
Message-ID: <2024052935-think-gaffe-80d4@gregkh> (raw)
In-Reply-To: <20240529083224.GA71473@sony.com>
On Wed, May 29, 2024 at 08:32:24AM +0000, Soumya Khasnis wrote:
> The device shutdown callbacks invoked during shutdown/reboot
> are prone to errors depending on the device state or mishandling
> by one or more driver. In order to prevent a device hang in such
> scenarios, we bail out after a timeout while dumping a meaningful
> call trace of the shutdown callback which blocks the shutdown or
> reboot process.
>
> Change-Id: Ibfc63ca8f8aa45866cbe6b90401d438d95eca742
Any reason you didn't run this through checkpatch.pl first?
:(
prev parent reply other threads:[~2024-05-29 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 8:32 [PATCH] reboot: Add timeout for device shutdown Soumya Khasnis
2024-05-29 10:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024052935-think-gaffe-80d4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Madhusudan.Bobbili@sony.com \
--cc=benjamin.bara@skidata.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.osipenko@collabora.com \
--cc=festevam@denx.de \
--cc=keita.aihara@sony.com \
--cc=ldmldm05@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masaya.takahashi@sony.com \
--cc=rafael@kernel.org \
--cc=shingo.takeuchi@sony.com \
--cc=soumya.khasnis@sony.com \
--cc=srinavasa.nagaraju@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox