public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Trimmer <simont@opensource.cirrus.com>
To: <tiwai@suse.com>
Cc: <linux-sound@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
	<soyer@irl.hu>, <shenghao-ding@ti.com>, <kevin-lu@ti.com>,
	<baojun.xu@ti.com>, <kailang@realtek.com>,
	Simon Trimmer <simont@opensource.cirrus.com>
Subject: [PATCH 1/7] ALSA: hda: cs35l56: Component should be unbound before deconstruction
Date: Fri, 31 May 2024 16:14:03 +0100	[thread overview]
Message-ID: <20240531151409.80284-2-simont@opensource.cirrus.com> (raw)
In-Reply-To: <20240531151409.80284-1-simont@opensource.cirrus.com>

The interface associated with the hda_component should be deactivated
before the driver is deconstructed during removal.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
---
 sound/pci/hda/cs35l56_hda.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 0923e2589f5f..e134ede6c5aa 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -1077,12 +1077,12 @@ void cs35l56_hda_remove(struct device *dev)
 {
 	struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
 
+	component_del(cs35l56->base.dev, &cs35l56_hda_comp_ops);
+
 	pm_runtime_dont_use_autosuspend(cs35l56->base.dev);
 	pm_runtime_get_sync(cs35l56->base.dev);
 	pm_runtime_disable(cs35l56->base.dev);
 
-	component_del(cs35l56->base.dev, &cs35l56_hda_comp_ops);
-
 	cs_dsp_remove(&cs35l56->cs_dsp);
 
 	kfree(cs35l56->system_name);
-- 
2.34.1


  reply	other threads:[~2024-05-31 15:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 15:14 [PATCH 0/7] ALSA: hda: Improvements to hda_component Simon Trimmer
2024-05-31 15:14 ` Simon Trimmer [this message]
2024-05-31 15:14 ` [PATCH 2/7] ALSA: hda: cs35l41: Component should be unbound before deconstruction Simon Trimmer
2024-05-31 15:14 ` [PATCH 3/7] ALSA: hda/tas2781: " Simon Trimmer
2024-05-31 15:14 ` [PATCH 4/7] ALSA: hda: hda_component: Introduce component parent structure Simon Trimmer
2024-05-31 19:58   ` kernel test robot
2024-06-01  3:02   ` kernel test robot
2024-05-31 15:14 ` [PATCH 5/7] ALSA: hda: hda_component: Change codecs to use " Simon Trimmer
2024-05-31 15:14 ` [PATCH 6/7] ALSA: hda: hda_component: Move codec field into the parent Simon Trimmer
2024-05-31 15:14 ` [PATCH 7/7] ALSA: hda: hda_component: Protect shared data with a mutex Simon Trimmer
  -- strict thread matches above, loose matches on Subject: below --
2024-06-03 10:35 [PATCH v2 0/7] ALSA: hda: Improvements to hda_component Simon Trimmer
2024-06-03 10:35 ` [PATCH 1/7] ALSA: hda: cs35l56: Component should be unbound before deconstruction Simon Trimmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531151409.80284-2-simont@opensource.cirrus.com \
    --to=simont@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=baojun.xu@ti.com \
    --cc=kailang@realtek.com \
    --cc=kevin-lu@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=shenghao-ding@ti.com \
    --cc=soyer@irl.hu \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox