* [PATCH] can: mscan: remove unused struct 'mscan_state'
@ 2024-05-25 23:25 linux
2024-05-31 15:40 ` Simon Horman
2024-06-03 10:56 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-05-25 23:25 UTC (permalink / raw)
To: mkl, mailhol.vincent
Cc: linux-can, netdev, wsa, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'mscan_state' is unused since the original
commit afa17a500a36 ("net/can: add driver for mscan family &
mpc52xx_mscan").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/can/mscan/mscan.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index a6829cdc0e81..8c2a7bc64d3d 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -34,12 +34,6 @@ static const struct can_bittiming_const mscan_bittiming_const = {
.brp_inc = 1,
};
-struct mscan_state {
- u8 mode;
- u8 canrier;
- u8 cantier;
-};
-
static enum can_state state_map[] = {
CAN_STATE_ERROR_ACTIVE,
CAN_STATE_ERROR_WARNING,
--
2.45.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mscan: remove unused struct 'mscan_state'
2024-05-25 23:25 [PATCH] can: mscan: remove unused struct 'mscan_state' linux
@ 2024-05-31 15:40 ` Simon Horman
2024-06-03 10:56 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-05-31 15:40 UTC (permalink / raw)
To: linux; +Cc: mkl, mailhol.vincent, linux-can, netdev, wsa, linux-kernel
On Sun, May 26, 2024 at 12:25:09AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: mscan: remove unused struct 'mscan_state'
2024-05-25 23:25 [PATCH] can: mscan: remove unused struct 'mscan_state' linux
2024-05-31 15:40 ` Simon Horman
@ 2024-06-03 10:56 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2024-06-03 10:56 UTC (permalink / raw)
To: linux; +Cc: mkl, mailhol.vincent, linux-can, netdev, wsa, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Wow, that driver was a long time ago. Thanks for the flashback :)
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-03 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-25 23:25 [PATCH] can: mscan: remove unused struct 'mscan_state' linux
2024-05-31 15:40 ` Simon Horman
2024-06-03 10:56 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox