Re: [PATCH v2 2/5] usb: dwc3: Support quirk for writing high-low order

Jung Daehwan
2024-06-04T01:58:50Z

[-- Attachment #1: Type: text/plain, Size: 3391 bytes --]

On Tue, Jun 04, 2024 at 12:16:33AM +0000, Thinh Nguyen wrote:
> On Fri, May 31, 2024, Daehwan Jung wrote:
> > Set xhci "write-64-hi-lo-quirk" property via
> > "snps,xhci-write-64-hi-lo-quirk" property.
>
> Please describe the change as if the reader has no context of the other
> patches in the series.
>
Thanks for the comment. I will add it in next submission.
> >
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> > ---
>
> Please provide change note for v2.
I will do it.
>
> > drivers/usb/dwc3/core.c | 3 +++
> > drivers/usb/dwc3/core.h | 2 ++
> > drivers/usb/dwc3/host.c | 5 ++++-
> > 3 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > index 7ee61a8..89985fd 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1716,6 +1716,9 @@ static void dwc3_get_properties(struct dwc3 *dwc)
> > dwc->dis_split_quirk = device_property_read_bool(dev,
> > "snps,dis-split-quirk");
> >
> > + dwc->xhci_write_64_hi_lo_quirk = device_property_read_bool(dev,
> > + "snps,xhci-write-64-hi-lo-quirk");
> > +
> > dwc->lpm_nyet_threshold = lpm_nyet_threshold;
> > dwc->tx_de_emphasis = tx_de_emphasis;
> >
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> > index 3781c73..ab5913c 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -1142,6 +1142,7 @@ struct dwc3_scratchpad_array {
> > * 3 - Reserved
> > * @dis_metastability_quirk: set to disable metastability quirk.
> > * @dis_split_quirk: set to disable split boundary.
> > + * @xhci_write_64_hi_lo_quirk: set if we enable quirk for writing in high-low order.
>
> The description should be more detail here. But I don't think we need
> this. Just pass the PROPERTY_ENTRY_BOOL("write-64-hi-lo-quirk") to xhci
> platform unconditionally. This should apply to all released versions (at
> the moment) of DWC_usb3x.
>
I got it. If so, I also think it's not needed. I will remove this.
> > * @sys_wakeup: set if the device may do system wakeup.
> > * @wakeup_configured: set if the device is configured for remote wakeup.
> > * @suspended: set to track suspend event due to U3/L2.
> > @@ -1369,6 +1370,7 @@ struct dwc3 {
> > unsigned dis_metastability_quirk:1;
> >
> > unsigned dis_split_quirk:1;
> > + unsigned xhci_write_64_hi_lo_quirk:1;
> > unsigned async_callbacks:1;
> > unsigned sys_wakeup:1;
> > unsigned wakeup_configured:1;
> > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> > index a171b27..8cc0def 100644
> > --- a/drivers/usb/dwc3/host.c
> > +++ b/drivers/usb/dwc3/host.c
> > @@ -126,7 +126,7 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
> >
> > int dwc3_host_init(struct dwc3 *dwc)
> > {
> > - struct property_entry props[5];
> > + struct property_entry props[6];
> > struct platform_device *xhci;
> > int ret, irq;
> > int prop_idx = 0;
> > @@ -162,6 +162,9 @@ int dwc3_host_init(struct dwc3 *dwc)
> >
> > props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-sg-trb-cache-size-quirk");
> >
> > + if (dwc->xhci_write_64_hi_lo_quirk)
> > + props[prop_idx++] = PROPERTY_ENTRY_BOOL("write-64-hi-lo-quirk");
> > +
> > if (dwc->usb3_lpm_capable)
> > props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb3-lpm-capable");
> >
> > --
> > 2.7.4
> >
>
Best Regards,
Jung Daehwan
> Thanks,
> Thinh

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]