From: kernel test robot <lkp@intel.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>
Subject: drivers/iommu/io-pgtable-arm.c:330:13: error: void value not ignored as it ought to be
Date: Mon, 3 Jun 2024 14:37:54 +0800 [thread overview]
Message-ID: <202406031408.wNSVlKLV-lkp@intel.com> (raw)
Hi Mark,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c3f38fa61af77b49866b006939479069cd451173
commit: 9257959a6e5b4fca6fc8e985790bff62c2046f20 locking/atomic: scripts: restructure fallback ifdeffery
date: 12 months ago
config: arc-randconfig-r022-20230104 (https://download.01.org/0day-ci/archive/20240603/202406031408.wNSVlKLV-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240603/202406031408.wNSVlKLV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406031408.wNSVlKLV-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/iommu/io-pgtable-arm.c: In function 'arm_lpae_install_table':
>> drivers/iommu/io-pgtable-arm.c:330:13: error: void value not ignored as it ought to be
330 | old = cmpxchg64_relaxed(ptep, curr, new);
| ^
--
drivers/iommu/io-pgtable-dart.c: In function 'dart_install_table':
>> drivers/iommu/io-pgtable-dart.c:168:13: error: void value not ignored as it ought to be
168 | old = cmpxchg64_relaxed(ptep, curr, new);
| ^
drivers/iommu/io-pgtable-dart.c:157:25: warning: variable 'new' set but not used [-Wunused-but-set-variable]
157 | dart_iopte old, new;
| ^~~
vim +330 drivers/iommu/io-pgtable-arm.c
c896c132b01895 Laurent Pinchart 2014-12-14 310
fb3a95795da53d Robin Murphy 2017-06-22 311 static arm_lpae_iopte arm_lpae_install_table(arm_lpae_iopte *table,
fb3a95795da53d Robin Murphy 2017-06-22 312 arm_lpae_iopte *ptep,
2c3d273eabe8b1 Robin Murphy 2017-06-22 313 arm_lpae_iopte curr,
9abe2ac834851a Hector Martin 2021-11-20 314 struct arm_lpae_io_pgtable *data)
fb3a95795da53d Robin Murphy 2017-06-22 315 {
2c3d273eabe8b1 Robin Murphy 2017-06-22 316 arm_lpae_iopte old, new;
9abe2ac834851a Hector Martin 2021-11-20 317 struct io_pgtable_cfg *cfg = &data->iop.cfg;
e1d3c0fd701df8 Will Deacon 2014-11-14 318
9abe2ac834851a Hector Martin 2021-11-20 319 new = paddr_to_iopte(__pa(table), data) | ARM_LPAE_PTE_TYPE_TABLE;
fb3a95795da53d Robin Murphy 2017-06-22 320 if (cfg->quirks & IO_PGTABLE_QUIRK_ARM_NS)
fb3a95795da53d Robin Murphy 2017-06-22 321 new |= ARM_LPAE_PTE_NSTABLE;
e1d3c0fd701df8 Will Deacon 2014-11-14 322
77f3445866c39d Will Deacon 2017-06-23 323 /*
77f3445866c39d Will Deacon 2017-06-23 324 * Ensure the table itself is visible before its PTE can be.
77f3445866c39d Will Deacon 2017-06-23 325 * Whilst we could get away with cmpxchg64_release below, this
77f3445866c39d Will Deacon 2017-06-23 326 * doesn't have any ordering semantics when !CONFIG_SMP.
77f3445866c39d Will Deacon 2017-06-23 327 */
77f3445866c39d Will Deacon 2017-06-23 328 dma_wmb();
2c3d273eabe8b1 Robin Murphy 2017-06-22 329
2c3d273eabe8b1 Robin Murphy 2017-06-22 @330 old = cmpxchg64_relaxed(ptep, curr, new);
2c3d273eabe8b1 Robin Murphy 2017-06-22 331
4f41845b340783 Will Deacon 2019-06-25 332 if (cfg->coherent_walk || (old & ARM_LPAE_PTE_SW_SYNC))
2c3d273eabe8b1 Robin Murphy 2017-06-22 333 return old;
2c3d273eabe8b1 Robin Murphy 2017-06-22 334
2c3d273eabe8b1 Robin Murphy 2017-06-22 335 /* Even if it's not ours, there's no point waiting; just kick it */
41e1eb2546e9c8 Isaac J. Manjarres 2021-06-16 336 __arm_lpae_sync_pte(ptep, 1, cfg);
2c3d273eabe8b1 Robin Murphy 2017-06-22 337 if (old == curr)
2c3d273eabe8b1 Robin Murphy 2017-06-22 338 WRITE_ONCE(*ptep, new | ARM_LPAE_PTE_SW_SYNC);
2c3d273eabe8b1 Robin Murphy 2017-06-22 339
2c3d273eabe8b1 Robin Murphy 2017-06-22 340 return old;
e1d3c0fd701df8 Will Deacon 2014-11-14 341 }
e1d3c0fd701df8 Will Deacon 2014-11-14 342
:::::: The code at line 330 was first introduced by commit
:::::: 2c3d273eabe8b1ed3b3cffe2c79643b1bf7e2d4a iommu/io-pgtable-arm: Support lockless operation
:::::: TO: Robin Murphy <robin.murphy@arm.com>
:::::: CC: Will Deacon <will.deacon@arm.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-06-03 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 6:37 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-06 23:58 drivers/iommu/io-pgtable-arm.c:330:13: error: void value not ignored as it ought to be kernel test robot
2024-07-08 11:42 ` Mark Rutland
2024-03-04 19:11 kernel test robot
2023-10-13 19:30 kernel test robot
2023-07-24 22:43 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406031408.wNSVlKLV-lkp@intel.com \
--to=lkp@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox